seongjinyoon commented on code in PR #3666:
URL: https://github.com/apache/texera/pull/3666#discussion_r2281347015
##########
core/file-service/src/main/scala/edu/uci/ics/texera/service/resource/DatasetResource.scala:
##########
@@ -1311,13 +1296,13 @@ class DatasetResource {
val datasets =
datasetDao.fetchByName(resolvedDatasetName).asScala.toList
if (datasets.nonEmpty) {
val dataset = datasets.head
- // Non-owners can only download public and downloadable datasets
+ // Non-owners can download if dataset is downloadable and they
have read access
if (
!userOwnDataset(
ctx,
dataset.getDid,
uid
- ) && (!dataset.getIsPublic || !dataset.getIsDownloadable)
+ ) && !dataset.getIsDownloadable
) {
throw new ForbiddenException("Dataset download is not allowed")
Review Comment:
outdated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
