AnzhiZhang commented on code in PR #3667:
URL: https://github.com/apache/texera/pull/3667#discussion_r2296773560
##########
core/gui/src/app/common/util/workflow-compilation-utils.ts:
##########
@@ -30,7 +31,7 @@ export function areAllPortSchemasEqual(schemas: (PortSchema |
undefined)[]): boo
if (schemas.length <= 1) {
return true;
}
- return schemas.every(schema => schema === schemas[0]);
+ return schemas.every(schema => isEqual(schemas[0], schema));
Review Comment:
```ts
import { isEqual } from "lodash";
// true
console.log(isEqual(undefined, undefined));
// true
console.log(isEqual(null, null));
// false
console.log(isEqual(undefined, null));
// false true
console.log(isEqual({}, {}));
console.log({} === {});
// false true
console.log({ a: 1 } === { a: 1 });
console.log(isEqual({ a: 1 }, { a: 1 }));
// false false
console.log({ a: 1 } === undefined);
console.log(isEqual({ a: 1 }, undefined));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
