xuang7 opened a new pull request, #3700:
URL: https://github.com/apache/texera/pull/3700
### **Purpose**
This PR resolves issue #3699 where the branding preview on the Admin General
Settings page was only applied to newly uploaded assets. It extends the preview
functionality to also display the currently used assets (logo, mini logo,
favicon), improving clarity and usability for administrators.
### **Changes**
- **Branding Preview**: Load default values from the database and display
the current branding in the preview section (logo, mini logo, favicon), reusing
the same UI as for new uploads.
- **Save/Reset Logic**: Simplified saveLogos() and resetBranding() to follow
the same patterns as other settings for consistency.
- Combined save/reset into a single feedback message to avoid redundancy
(e.g., “Branding saved successfully”, “Branding reset”, or error messages).
- **Reload Delay**: Extracted reload timing into a constant private readonly
RELOAD_DELAY = 1000. Branding changes now refresh after 1s.
### **Demonstration**
| Before | After |
|--------|-------|
| <img width="760" height="457" alt="before-preview"
src="https://github.com/user-attachments/assets/9a31a697-5553-4545-a1d6-0aaa95305b30";
/> | <img width="817" height="457" alt="after-preview"
src="https://github.com/user-attachments/assets/b7dfff61-7ce7-4e8c-b330-7c9828e9f175";
/> |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
