GitHub user Yicong-Huang added a comment to the discussion: Approach: landing Modern Observability (#4070) as a stack of small, self-contained PRs
Hi @Ma77Ball, I don't have time to verify the project details yet, just a comment on opening issues and PRs related to a big topic. It will be good to have an umbrella issue (for example #4070) and on that issue to describe your plan. Then you can open multiple sub issues, each as a todo. The sub issues can be in parallel or in sequential to be completed. For PRs though, if you find yourself stacking PRs (meaning that PR B depends on PR A, and PR C depends on PR B), then I suggest you open them one by one to make review easier: - reviewer's attention needs to focus on incremental diff between the stacked PRs, and because github limitation, all PRs are against main branch, then PR B will contain diffs from PR A, and PR C will contain diffs from both A and B. It is hard for reviewers to check. - for author, you, to resolve comments from PR A, you will likely need to push code and change the branch. Then you need to rebase or merge PR B and C, that's a lot of workload for author as well. So my point is, you can open many issues (todos), but for PRs, it's better to open one at a time to get reviewed. If you have something that has no dependency and can be done/reviewed in parallel, sure you can open multiple PRs for those kind of parallel tasks. I see you had more than 8(?) stacked PRs opening right now, and as a potential reviewer I am a bit lost where to start. for you, you need to update the other 7 as the first PR evolves, that's a lot of waste of time. GitHub link: https://github.com/apache/texera/discussions/5355#discussioncomment-17196834 ---- This is an automatically sent email for [email protected]. To unsubscribe, please send an email to: [email protected]
