[
https://issues.apache.org/jira/browse/THRIFT-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987576#action_12987576
]
Christian Lavoie commented on THRIFT-993:
-----------------------------------------
Sorry this slipped through the cracks in November, I wish it hadn't.
I still think the oneway caching is pointless and obscurs the code -- even the
simplest optimizers will safely remove the function call, and caching it risks
getting it wrong now or in the future.
The rest is a nice cleanup.
> Some improvements in C++ stubs for oneway operations
> ----------------------------------------------------
>
> Key: THRIFT-993
> URL: https://issues.apache.org/jira/browse/THRIFT-993
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Compiler
> Reporter: Rich Salz
> Priority: Minor
> Attachments: diff.txt
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Oneway operations don't use the seqid or oprot parameters, so the generated
> stub should use unnamed parameters for those.
> While changing this I noticed that tfunction->is_oneway() is called many
> times, so cache that result in a local variable.
> While making that change, I noticed what seems to be an extraneous test for
> that, inside a loop which is already inside an if branch. I just commented
> that.
> So far, these changes make generated thrift stubs pass g++ -Wunused cleanly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
