[ https://issues.apache.org/jira/browse/THRIFT-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987666#action_12987666 ]
Rich Salz commented on THRIFT-993: ---------------------------------- Thanks for the kind words, Christian. I don't really care about "bool oneway" very much. I found it useful because it's shorter to type and because it made it clear that is_oneway() never changed on me. But as I said, that's less important than the other changes. > Some improvements in C++ stubs for oneway operations > ---------------------------------------------------- > > Key: THRIFT-993 > URL: https://issues.apache.org/jira/browse/THRIFT-993 > Project: Thrift > Issue Type: Improvement > Components: C++ - Compiler > Reporter: Rich Salz > Priority: Minor > Attachments: diff.txt > > Original Estimate: 1h > Remaining Estimate: 1h > > Oneway operations don't use the seqid or oprot parameters, so the generated > stub should use unnamed parameters for those. > While changing this I noticed that tfunction->is_oneway() is called many > times, so cache that result in a local variable. > While making that change, I noticed what seems to be an extraneous test for > that, inside a loop which is already inside an if branch. I just commented > that. > So far, these changes make generated thrift stubs pass g++ -Wunused cleanly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.