[ 
https://issues.apache.org/jira/browse/THRIFT-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049408#comment-13049408
 ] 

Michael Stockton commented on THRIFT-1204:
------------------------------------------

Thrift wasn't always primarily distributed as a gem. The Makefile will install 
libraries in site_ruby. In no way am I suggesting this is a good thing because 
it does cause confusion, but just how things are until 'make install' installs 
a gem.

I agree with your sentiment to make things easier for irb environments. Though, 
you could require rubygems via .irbrc. I guess my point (or slight preference) 
is that the requirement for rubygems should happen at a developer's discretion. 
I know lots of gems do it, but I find it odd for a library/stub to do it for 
me... 

On a side note, if we do require rubygems in stubs, it would nice to bind them 
to a thrift library version (e.g. gem "thrift", "= 0.6.0"). This would help 
people catch incompatibilities between stubs and their thrift library.

I'll be happy either way. Just my two cents.





> Ruby autogenerated files should require 'thrift' gem
> ----------------------------------------------------
>
>                 Key: THRIFT-1204
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1204
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Ruby - Compiler
>    Affects Versions: 0.6.1
>         Environment: All
>            Reporter: Ilya Maykov
>            Assignee: Ilya Maykov
>            Priority: Minor
>         Attachments: THRIFT-1204-require-thrift-in-gen-rb-files.patch
>
>
> The gen-rb files currently don't require the thrift gem. This means that the 
> user of such a file must explicitly require 'thrift' in his code before 
> requiring a gen-rb file, which can be a bit annoying (especially when 
> debugging / experimenting in IRB). I propose that we change the compiler to 
> add the require at the top of every gen-rb file.
> Patch coming shortly.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to