[ 
https://issues.apache.org/jira/browse/THRIFT-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ilya Maykov updated THRIFT-1204:
--------------------------------

    Attachment: THRIFT-1204-require-thrift-in-gen-rb-files.patch

New patch which does 2 things:

1) Adds a "require 'thrift'" line to the *_types.rb and *_constants.rb files, 
to be consistent with *_service.rb which was generating the thrift require 
already.
2) Adds a "rubygems" option to the --gen rb compiler target. When this option 
is specified, the compiler will add a "require 'rubygems'" line to the top of 
each gen-rb file. Defaults to false.
                
> Ruby autogenerated files should require 'thrift' gem
> ----------------------------------------------------
>
>                 Key: THRIFT-1204
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1204
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Ruby - Compiler
>    Affects Versions: 0.6.1
>         Environment: All
>            Reporter: Ilya Maykov
>            Assignee: Ilya Maykov
>            Priority: Minor
>         Attachments: THRIFT-1204-require-thrift-in-gen-rb-files.patch
>
>
> The gen-rb files currently don't require the thrift gem. This means that the 
> user of such a file must explicitly require 'thrift' in his code before 
> requiring a gen-rb file, which can be a bit annoying (especially when 
> debugging / experimenting in IRB). I propose that we change the compiler to 
> add the require at the top of every gen-rb file.
> Patch coming shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to