[
https://issues.apache.org/jira/browse/THRIFT-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier resolved THRIFT-1320.
---------------------------------
Resolution: Fixed
Thanks Alexandre!
just committed.
> Consistency of configure generated config.h
> -------------------------------------------
>
> Key: THRIFT-1320
> URL: https://issues.apache.org/jira/browse/THRIFT-1320
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Affects Versions: 0.8
> Environment: Linux, Windows
> Reporter: alexandre parenteau
> Priority: Trivial
> Labels: patch
> Fix For: 0.8
>
> Attachments: THRIFT-1320.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> In an attempt to minimize the differences inherent to the various Windows
> ports (THRIFT-923, THRIFT-1123, THRIFT-1031, THRIFT-591...), and to fix some
> inconsistencies related to the inclusion of config.h, enclosed is a patch
> over current trunk which attempts to reconcile the usage of the configure
> generated file.
> Due to my lack of knowledge about the thrift code base, the patch is probably
> incomplete and does apply only to the thrift/thriftnb C++ libraries, ignoring
> the other C++ components (compiler, test...).
> Side note: This patch is part of an attempt to maintain a Windows port for
> thriftnb
> (https://github.com/aubonbeurre/thrift/blob/winthriftnb-0.8.x/README.non.blocking.Windows)
> Tested on Ubuntu and Windows.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
