[ https://issues.apache.org/jira/browse/THRIFT-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097292#comment-13097292 ]
Hudson commented on THRIFT-1320: -------------------------------- Integrated in Thrift #249 (See [https://builds.apache.org/job/Thrift/249/]) THRIFT-1320 Consistency of configure generated config.h Patch: Alexandre Parenteau roger : http://svn.apache.org/viewvc/?view=rev&rev=1165400 Files : * /thrift/trunk/configure.ac * /thrift/trunk/lib/cpp/src/Thrift.h * /thrift/trunk/lib/cpp/src/concurrency/Mutex.cpp * /thrift/trunk/lib/cpp/src/concurrency/Util.cpp * /thrift/trunk/lib/cpp/src/concurrency/Util.h * /thrift/trunk/lib/cpp/src/protocol/TProtocol.h * /thrift/trunk/lib/cpp/src/server/TNonblockingServer.cpp * /thrift/trunk/lib/cpp/src/server/TServer.cpp * /thrift/trunk/lib/cpp/src/transport/TFDTransport.h * /thrift/trunk/lib/cpp/src/transport/TFileTransport.cpp * /thrift/trunk/lib/cpp/src/transport/TSSLSocket.cpp * /thrift/trunk/lib/cpp/src/transport/TServerSocket.cpp * /thrift/trunk/lib/cpp/src/transport/TSimpleFileTransport.cpp * /thrift/trunk/lib/cpp/src/transport/TSocket.cpp * /thrift/trunk/lib/cpp/src/transport/TSocket.h * /thrift/trunk/lib/cpp/test/Benchmark.cpp * /thrift/trunk/lib/cpp/test/TFileTransportTest.cpp > Consistency of configure generated config.h > ------------------------------------------- > > Key: THRIFT-1320 > URL: https://issues.apache.org/jira/browse/THRIFT-1320 > Project: Thrift > Issue Type: Improvement > Components: C++ - Library > Affects Versions: 0.8 > Environment: Linux, Windows > Reporter: alexandre parenteau > Priority: Trivial > Labels: patch > Fix For: 0.8 > > Attachments: THRIFT-1320.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > In an attempt to minimize the differences inherent to the various Windows > ports (THRIFT-923, THRIFT-1123, THRIFT-1031, THRIFT-591...), and to fix some > inconsistencies related to the inclusion of config.h, enclosed is a patch > over current trunk which attempts to reconcile the usage of the configure > generated file. > Due to my lack of knowledge about the thrift code base, the patch is probably > incomplete and does apply only to the thrift/thriftnb C++ libraries, ignoring > the other C++ components (compiler, test...). > Side note: This patch is part of an attempt to maintain a Windows port for > thriftnb > (https://github.com/aubonbeurre/thrift/blob/winthriftnb-0.8.x/README.non.blocking.Windows) > Tested on Ubuntu and Windows. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira