[ 
https://issues.apache.org/jira/browse/THRIFT-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13123202#comment-13123202
 ] 

Jens Geyer commented on THRIFT-1366:
------------------------------------

Revision 6 looks good to me: +1 for this one.

I checked both code generation and library extensively using Delphi XE. Tried 
to build a simple independent client project against Cassandra (0.6.0), which 
worked as expected. Another server/client testcase is included in the package, 
this also works w/o problems. Problems found during review have been solved.

I'd just like to see the ReservedKeywords.thrift file to be included as well.
                
> Delphi generator, lirbrary and unit test.
> -----------------------------------------
>
>                 Key: THRIFT-1366
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1366
>             Project: Thrift
>          Issue Type: New Feature
>            Reporter: Kenjiro Fukumitsu
>         Attachments: ReservedKeywords.zip, 
> THRIFT-1366_delphi_generator_lib_test_v2.zip, 
> THRIFT-1366_delphi_generator_lib_test_v3.zip, 
> THRIFT-1366_delphi_generator_lib_test_v4.zip, 
> THRIFT-1366_delphi_generator_lib_test_v5.zip, 
> THRIFT-1366_delphi_generator_lib_test_v6.zip
>
>
> I wrote Delphi generator, lirbrary and unit test.
> It works with Delphi XE.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to