[
https://issues.apache.org/jira/browse/THRIFT-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124712#comment-13124712
]
Kenjiro Fukumitsu edited comment on THRIFT-1366 at 10/11/11 5:46 AM:
---------------------------------------------------------------------
I updated the patch. Please see THRIFT-1366_delphi_generator_lib_test_v7.zip.
I fixed few problems mentioned in the review and the problems I found by myself
in the past few days.
* Changed the code of memory block copy in the library, to make it simpler.
* Removed the functions in library that are not used anymore.
* Removed unnecessary comments from generator code.
* Changed identifier checking fucntion to handle method names of base exception
class correctly.
* Fixed the problem that an indent is inclemented permanently after generating
exception class.
* Changed the generator code to replace white spaces in unitname with
underscore.(THRIFT-1383)
was (Author: kenjiro):
I updated the patch. Please see
THRIFT-1366_delphi_generator_lib_test_v7.zip.
I fixed few problems mentioned in the review and the problems I found by myself
in the past few days.
* Changed the code of memory block copy in the library, to make it simpler.
* Removed the functions in library that are not used anymore.
* Removed unnecessary comments from generator code.
* Changed identifier checking fucntion to handle method names of base exception
class correctly.
* Fixed the problem that an indent is inclemented permanently after generating
exception class.
* Changed the generator code to replace white spaces in unitname with
underscore.
> Delphi generator, lirbrary and unit test.
> -----------------------------------------
>
> Key: THRIFT-1366
> URL: https://issues.apache.org/jira/browse/THRIFT-1366
> Project: Thrift
> Issue Type: New Feature
> Reporter: Kenjiro Fukumitsu
> Assignee: Jake Farrell
> Attachments: ReservedKeywords.zip,
> THRIFT-1366_delphi_generator_lib_test_v2.zip,
> THRIFT-1366_delphi_generator_lib_test_v3.zip,
> THRIFT-1366_delphi_generator_lib_test_v4.zip,
> THRIFT-1366_delphi_generator_lib_test_v5.zip,
> THRIFT-1366_delphi_generator_lib_test_v6.zip,
> THRIFT-1366_delphi_generator_lib_test_v7.zip
>
>
> I wrote Delphi generator, lirbrary and unit test.
> It works with Delphi XE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
