[ https://issues.apache.org/jira/browse/THRIFT-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141184#comment-13141184 ]
Mike Riley commented on THRIFT-1330: ------------------------------------ I have these fixed locally. However, I'm working off of the 0.7 tag as I'm unable to get the C++ server libraries from trunk to work within my application. AFAIK there is no conflict there but I haven't tried patching into trunk yet. I also have several other areas within thrift that I've been tooling around with and will need to pluck only the pertinent parts out of the php compiler. Won't take much time, but if it's all the same, I'd like to wait until Saturday to put it all together. > PHP Namespaces no longer generated > ---------------------------------- > > Key: THRIFT-1330 > URL: https://issues.apache.org/jira/browse/THRIFT-1330 > Project: Thrift > Issue Type: Bug > Components: PHP - Compiler > Affects Versions: 0.7, 0.8 > Environment: Mac OS X 10.6.8, CentOS 5.6, Ubuntu 11.04 > Reporter: B Armstrong > Assignee: Jake Farrell > Priority: Critical > > PHP namespaces are not being generated, ever. PHP 5.3 namespace aren't > generated either. > The following will illustrate the bug. This works in Thrift 0.6.* > $ thrift -version > Thrift version 0.7.0 > $ cat > test.thrift > namespace php TestNamespace > struct ItemX {} > $ thrift --gen php test.thrift > $ grep "TestNamespace" gen-php/test/test_types.php && echo "Has namespace" || > echo "NO NAMESPACE FOUND" > NO NAMESPACE FOUND > $ thrift -version > Thrift version 0.8.0-dev > $ thrift -gen php test.thrift > $ grep "TestNamespace" gen-php/test/test_types.php && echo "Has namespace" || > echo "NO NAMESPACE FOUND" > NO NAMESPACE FOUND -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira