[ 
https://issues.apache.org/jira/browse/THRIFT-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157541#comment-13157541
 ] 

Mike Riley commented on THRIFT-1330:
------------------------------------

I can confirm this occurs, however this has been the behavior present since at 
least 0.7x, the file/folder structure is identical. I suppose it never really 
occurred to me that this was unexpected behavior since I am using namespaces to 
separate thrift code from my non-generated code and only have one namespace to 
worry about as far as thrift is concerned.

Could you describe the expected behavior for me so I can try and fix this?
                
> PHP Namespaces no longer generated
> ----------------------------------
>
>                 Key: THRIFT-1330
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1330
>             Project: Thrift
>          Issue Type: Bug
>          Components: PHP - Compiler
>    Affects Versions: 0.7, 0.8
>         Environment: Mac OS X 10.6.8, CentOS 5.6, Ubuntu 11.04
>            Reporter: B Armstrong
>            Assignee: Jake Farrell
>            Priority: Critical
>             Fix For: 0.8
>
>         Attachments: thrift-1392-1330.patch, thrift-1392-1330r1.patch
>
>
> PHP namespaces are not being generated, ever. PHP 5.3 namespace aren't 
> generated either.
> The following will illustrate the bug. This works in Thrift 0.6.*
> $ thrift -version
> Thrift version 0.7.0
> $ cat > test.thrift
> namespace php TestNamespace
> struct ItemX {}
> $ thrift --gen php test.thrift
> $ grep "TestNamespace" gen-php/test/test_types.php && echo "Has namespace" || 
> echo "NO NAMESPACE FOUND"
> NO NAMESPACE FOUND
> $ thrift -version
> Thrift version 0.8.0-dev
> $ thrift -gen php test.thrift 
> $ grep "TestNamespace" gen-php/test/test_types.php && echo "Has namespace" || 
> echo "NO NAMESPACE FOUND"
> NO NAMESPACE FOUND

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to