[ 
https://issues.apache.org/jira/browse/THRIFT-1412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251831#comment-13251831
 ] 

Roger Meier commented on THRIFT-1412:
-------------------------------------

I use Debian and with mono-gmcs(2.6.7-5) and have the following issue:
{noformat}
/thrift/lib/csharp$ make
gmcs src/Collections/THashSet.cs src/Properties/AssemblyInfo.cs 
src/Protocol/TBase.cs src/Protocol/TBase64Utils.cs 
src/Protocol/TJSONProtocol.cs src/Protocol/TProtocolException.cs 
src/Protocol/TProtocolFactory.cs src/Protocol/TList.cs src/Protocol/TSet.cs 
src/Protocol/TMap.cs src/Protocol/TProtocolUtil.cs src/Protocol/TMessageType.cs 
src/Protocol/TProtocol.cs src/Protocol/TType.cs src/Protocol/TField.cs 
src/Protocol/TMessage.cs src/Protocol/TStruct.cs 
src/Protocol/TBinaryProtocol.cs src/Server/TThreadedServer.cs 
src/Server/TThreadPoolServer.cs src/Server/TSimpleServer.cs 
src/Server/TServer.cs src/Transport/TBufferedTransport.cs 
src/Transport/TTransport.cs src/Transport/TSocket.cs 
src/Transport/TTransportException.cs src/Transport/TStreamTransport.cs 
src/Transport/TFramedTransport.cs src/Transport/TServerTransport.cs 
src/Transport/TServerSocket.cs src/Transport/TTransportFactory.cs 
src/Transport/THttpClient.cs src/Transport/THttpHandler.cs src/TProcessor.cs 
src/TApplicationException.cs /out:Thrift.dll /target:library 
/reference:System.Web
src/Transport/TBufferedTransport.cs(103,18): error CS0116: A namespace can only 
contain types and namespace declarations
src/Transport/TBufferedTransport.cs(106,29): error CS0116: A namespace can only 
contain types and namespace declarations
src/Transport/TBufferedTransport.cs(122,1): error CS8025: Parsing error
Compilation failed: 3 error(s), 0 warnings
make: *** [Thrift.dll] Error 1

{noformat}

any idea how to fix or ifdef patch to differentiate windows and mono?
                
> Thrift Transport classes should manage the lifetime of objects implementing 
> IDisposable by implementing IDisposable themselves.
> -------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-1412
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1412
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C# - Library
>    Affects Versions: 0.7
>            Reporter: Joshua Garvin
>              Labels: patch
>         Attachments: Thrift Transport with IDisposable.patch, 
> Thrift-trunk-iDisposable v2.patch, Thrift-trunk-iDisposable.patch
>
>
> I have attached a patch to the C# Transport classes to implement IDisposable 
> where needed.  This will ensure that all unmanaged resources such as streams 
> and sockets are properly closed and freed from memory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to