[ https://issues.apache.org/jira/browse/THRIFT-1412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251983#comment-13251983 ]
Hudson commented on THRIFT-1412: -------------------------------- Integrated in Thrift #433 (See [https://builds.apache.org/job/Thrift/433/]) THRIFT-1412 Thrift Transport classes should manage the lifetime of objects implementing IDisposable by implementing IDisposable themselves Patch: Joshua Garvin (Revision 1325013) Result = FAILURE roger : http://svn.apache.org/viewvc/?view=rev&rev=1325013 Files : * /thrift/trunk/lib/csharp/src/Server/TSimpleServer.cs * /thrift/trunk/lib/csharp/src/Server/TThreadPoolServer.cs * /thrift/trunk/lib/csharp/src/Server/TThreadedServer.cs * /thrift/trunk/lib/csharp/src/Transport/TBufferedTransport.cs * /thrift/trunk/lib/csharp/src/Transport/TFramedTransport.cs * /thrift/trunk/lib/csharp/src/Transport/THttpClient.cs * /thrift/trunk/lib/csharp/src/Transport/TServerSocket.cs * /thrift/trunk/lib/csharp/src/Transport/TSocket.cs * /thrift/trunk/lib/csharp/src/Transport/TStreamTransport.cs * /thrift/trunk/lib/csharp/src/Transport/TTransport.cs > Thrift Transport classes should manage the lifetime of objects implementing > IDisposable by implementing IDisposable themselves. > ------------------------------------------------------------------------------------------------------------------------------- > > Key: THRIFT-1412 > URL: https://issues.apache.org/jira/browse/THRIFT-1412 > Project: Thrift > Issue Type: Improvement > Components: C# - Library > Affects Versions: 0.7 > Reporter: Joshua Garvin > Assignee: Joshua Garvin > Labels: patch > Attachments: Thrift Transport with IDisposable.patch, > Thrift-trunk-iDisposable v3.patch > > > I have attached a patch to the C# Transport classes to implement IDisposable > where needed. This will ensure that all unmanaged resources such as streams > and sockets are properly closed and freed from memory. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira