[
https://issues.apache.org/jira/browse/THRIFT-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253258#comment-13253258
]
Hudson commented on THRIFT-1552:
--------------------------------
Integrated in Thrift #435 (See [https://builds.apache.org/job/Thrift/435/])
THRIFT-1552 Thrift (cpp) include files shouldn't require adding "thrift" to
the compilers include path.
roger: some additional fixes (Revision 1325677)
THRIFT-1552 Include paths for c/c++ should be prefixed with 'thrift/'
To ensure there are no include path collisions the C and C++ header
include paths should include 'thrift' as the root leaf. This will
prevent having to place /usr/include/thrift into the compilers include
header search path, which might otherwise result in the compiler
accidentally picking up headers that it shouldn't.
e.g. #include <foo/bar.h> should be #include <thrift/foo/bar.h>
Change-Id: I48f2b0f549bda0fc81e85506ac857adc800b98a1 (Revision 1325674)
Result = SUCCESS
roger : http://svn.apache.org/viewvc/?view=rev&rev=1325677
Files :
* /thrift/trunk/lib/cpp/Makefile.am
* /thrift/trunk/lib/cpp/src/thrift/async/TAsyncProcessor.h
* /thrift/trunk/lib/cpp/src/thrift/qt/TQIODeviceTransport.cpp
* /thrift/trunk/lib/cpp/src/thrift/transport/TShortReadTransport.h
* /thrift/trunk/lib/cpp/test/AllProtocolTests.tcc
* /thrift/trunk/test/cpp/src/StressTest.cpp
* /thrift/trunk/test/cpp/src/StressTestNonBlocking.cpp
roger : http://svn.apache.org/viewvc/?view=rev&rev=1325674
Files :
* /thrift/trunk/LICENSE
* /thrift/trunk/compiler/cpp/compiler.vcxproj
* /thrift/trunk/compiler/cpp/src/generate/t_c_glib_generator.cc
* /thrift/trunk/compiler/cpp/src/generate/t_cpp_generator.cc
* /thrift/trunk/contrib/async-test/test-server.cpp
* /thrift/trunk/contrib/fb303/TClientInfo.cpp
* /thrift/trunk/contrib/fb303/TClientInfo.h
* /thrift/trunk/contrib/fb303/cpp/FacebookBase.h
* /thrift/trunk/contrib/fb303/cpp/ServiceTracker.cpp
* /thrift/trunk/contrib/fb303/cpp/ServiceTracker.h
* /thrift/trunk/contrib/thrift_dump.cpp
* /thrift/trunk/contrib/zeromq/TZmqClient.h
* /thrift/trunk/contrib/zeromq/TZmqServer.cpp
* /thrift/trunk/contrib/zeromq/TZmqServer.h
* /thrift/trunk/contrib/zeromq/test-client.cpp
* /thrift/trunk/contrib/zeromq/test-sender.cpp
* /thrift/trunk/lib/c_glib/Makefile.am
* /thrift/trunk/lib/c_glib/src/processor/thrift_processor.c
* /thrift/trunk/lib/c_glib/src/processor/thrift_processor.h
* /thrift/trunk/lib/c_glib/src/protocol/thrift_binary_protocol.c
* /thrift/trunk/lib/c_glib/src/protocol/thrift_binary_protocol.h
* /thrift/trunk/lib/c_glib/src/protocol/thrift_binary_protocol_factory.c
* /thrift/trunk/lib/c_glib/src/protocol/thrift_binary_protocol_factory.h
* /thrift/trunk/lib/c_glib/src/protocol/thrift_protocol.c
* /thrift/trunk/lib/c_glib/src/protocol/thrift_protocol.h
* /thrift/trunk/lib/c_glib/src/protocol/thrift_protocol_factory.c
* /thrift/trunk/lib/c_glib/src/protocol/thrift_protocol_factory.h
* /thrift/trunk/lib/c_glib/src/server/thrift_server.c
* /thrift/trunk/lib/c_glib/src/server/thrift_server.h
* /thrift/trunk/lib/c_glib/src/server/thrift_simple_server.c
* /thrift/trunk/lib/c_glib/src/server/thrift_simple_server.h
* /thrift/trunk/lib/c_glib/src/thrift
* /thrift/trunk/lib/c_glib/src/thrift.c
* /thrift/trunk/lib/c_glib/src/thrift.h
* /thrift/trunk/lib/c_glib/src/thrift/processor
* /thrift/trunk/lib/c_glib/src/thrift/processor/thrift_processor.c
* /thrift/trunk/lib/c_glib/src/thrift/processor/thrift_processor.h
* /thrift/trunk/lib/c_glib/src/thrift/protocol
* /thrift/trunk/lib/c_glib/src/thrift/protocol/thrift_binary_protocol.c
* /thrift/trunk/lib/c_glib/src/thrift/protocol/thrift_binary_protocol.h
* /thrift/trunk/lib/c_glib/src/thrift/protocol/thrift_binary_protocol_factory.c
* /thrift/trunk/lib/c_glib/src/thrift/protocol/thrift_binary_protocol_factory.h
* /thrift/trunk/lib/c_glib/src/thrift/protocol/thrift_protocol.c
* /thrift/trunk/lib/c_glib/src/thrift/protocol/thrift_protocol.h
* /thrift/trunk/lib/c_glib/src/thrift/protocol/thrift_protocol_factory.c
* /thrift/trunk/lib/c_glib/src/thrift/protocol/thrift_protocol_factory.h
* /thrift/trunk/lib/c_glib/src/thrift/server
* /thrift/trunk/lib/c_glib/src/thrift/server/thrift_server.c
* /thrift/trunk/lib/c_glib/src/thrift/server/thrift_server.h
* /thrift/trunk/lib/c_glib/src/thrift/server/thrift_simple_server.c
* /thrift/trunk/lib/c_glib/src/thrift/server/thrift_simple_server.h
* /thrift/trunk/lib/c_glib/src/thrift/thrift.c
* /thrift/trunk/lib/c_glib/src/thrift/thrift.h
* /thrift/trunk/lib/c_glib/src/thrift/thrift_application_exception.c
* /thrift/trunk/lib/c_glib/src/thrift/thrift_application_exception.h
* /thrift/trunk/lib/c_glib/src/thrift/thrift_struct.c
* /thrift/trunk/lib/c_glib/src/thrift/thrift_struct.h
* /thrift/trunk/lib/c_glib/src/thrift/transport
* /thrift/trunk/lib/c_glib/src/thrift/transport/thrift_buffered_transport.c
* /thrift/trunk/lib/c_glib/src/thrift/transport/thrift_buffered_transport.h
* /thrift/trunk/lib/c_glib/src/thrift/transport/thrift_framed_transport.c
* /thrift/trunk/lib/c_glib/src/thrift/transport/thrift_framed_transport.h
* /thrift/trunk/lib/c_glib/src/thrift/transport/thrift_memory_buffer.c
* /thrift/trunk/lib/c_glib/src/thrift/transport/thrift_memory_buffer.h
* /thrift/trunk/lib/c_glib/src/thrift/transport/thrift_server_socket.c
* /thrift/trunk/lib/c_glib/src/thrift/transport/thrift_server_socket.h
* /thrift/trunk/lib/c_glib/src/thrift/transport/thrift_server_transport.c
* /thrift/trunk/lib/c_glib/src/thrift/transport/thrift_server_transport.h
* /thrift/trunk/lib/c_glib/src/thrift/transport/thrift_socket.c
* /thrift/trunk/lib/c_glib/src/thrift/transport/thrift_socket.h
* /thrift/trunk/lib/c_glib/src/thrift/transport/thrift_transport.c
* /thrift/trunk/lib/c_glib/src/thrift/transport/thrift_transport.h
* /thrift/trunk/lib/c_glib/src/thrift/transport/thrift_transport_factory.c
* /thrift/trunk/lib/c_glib/src/thrift/transport/thrift_transport_factory.h
* /thrift/trunk/lib/c_glib/src/thrift_application_exception.c
* /thrift/trunk/lib/c_glib/src/thrift_application_exception.h
* /thrift/trunk/lib/c_glib/src/thrift_struct.c
* /thrift/trunk/lib/c_glib/src/thrift_struct.h
* /thrift/trunk/lib/c_glib/src/transport/thrift_buffered_transport.c
* /thrift/trunk/lib/c_glib/src/transport/thrift_buffered_transport.h
* /thrift/trunk/lib/c_glib/src/transport/thrift_framed_transport.c
* /thrift/trunk/lib/c_glib/src/transport/thrift_framed_transport.h
* /thrift/trunk/lib/c_glib/src/transport/thrift_memory_buffer.c
* /thrift/trunk/lib/c_glib/src/transport/thrift_memory_buffer.h
* /thrift/trunk/lib/c_glib/src/transport/thrift_server_socket.c
* /thrift/trunk/lib/c_glib/src/transport/thrift_server_socket.h
* /thrift/trunk/lib/c_glib/src/transport/thrift_server_transport.c
* /thrift/trunk/lib/c_glib/src/transport/thrift_server_transport.h
* /thrift/trunk/lib/c_glib/src/transport/thrift_socket.c
* /thrift/trunk/lib/c_glib/src/transport/thrift_socket.h
* /thrift/trunk/lib/c_glib/src/transport/thrift_transport.c
* /thrift/trunk/lib/c_glib/src/transport/thrift_transport.h
* /thrift/trunk/lib/c_glib/src/transport/thrift_transport_factory.c
* /thrift/trunk/lib/c_glib/src/transport/thrift_transport_factory.h
* /thrift/trunk/lib/c_glib/test/testbinaryprotocol.c
* /thrift/trunk/lib/c_glib/test/testbufferedtransport.c
* /thrift/trunk/lib/c_glib/test/testframedtransport.c
* /thrift/trunk/lib/c_glib/test/testmemorybuffer.c
* /thrift/trunk/lib/c_glib/test/testoptionalrequired.c
* /thrift/trunk/lib/c_glib/test/testsimpleserver.c
* /thrift/trunk/lib/c_glib/test/testthrifttest.c
* /thrift/trunk/lib/c_glib/test/testthrifttestclient.cpp
* /thrift/trunk/lib/c_glib/test/testtransportsocket.c
* /thrift/trunk/lib/cpp/Makefile.am
* /thrift/trunk/lib/cpp/libthrift.vcxproj
* /thrift/trunk/lib/cpp/libthrift.vcxproj.filters
* /thrift/trunk/lib/cpp/libthriftnb.vcxproj
* /thrift/trunk/lib/cpp/libthriftnb.vcxproj.filters
* /thrift/trunk/lib/cpp/src/TApplicationException.cpp
* /thrift/trunk/lib/cpp/src/TApplicationException.h
* /thrift/trunk/lib/cpp/src/TDispatchProcessor.h
* /thrift/trunk/lib/cpp/src/TLogging.h
* /thrift/trunk/lib/cpp/src/TProcessor.h
* /thrift/trunk/lib/cpp/src/TReflectionLocal.h
* /thrift/trunk/lib/cpp/src/Thrift.cpp
* /thrift/trunk/lib/cpp/src/Thrift.h
* /thrift/trunk/lib/cpp/src/VirtualProfiling.cpp
* /thrift/trunk/lib/cpp/src/async/TAsyncBufferProcessor.h
* /thrift/trunk/lib/cpp/src/async/TAsyncChannel.cpp
* /thrift/trunk/lib/cpp/src/async/TAsyncChannel.h
* /thrift/trunk/lib/cpp/src/async/TAsyncDispatchProcessor.h
* /thrift/trunk/lib/cpp/src/async/TAsyncProcessor.h
* /thrift/trunk/lib/cpp/src/async/TAsyncProtocolProcessor.cpp
* /thrift/trunk/lib/cpp/src/async/TAsyncProtocolProcessor.h
* /thrift/trunk/lib/cpp/src/async/TEvhttpClientChannel.cpp
* /thrift/trunk/lib/cpp/src/async/TEvhttpClientChannel.h
* /thrift/trunk/lib/cpp/src/async/TEvhttpServer.cpp
* /thrift/trunk/lib/cpp/src/async/TEvhttpServer.h
* /thrift/trunk/lib/cpp/src/concurrency/BoostMonitor.cpp
* /thrift/trunk/lib/cpp/src/concurrency/BoostMutex.cpp
* /thrift/trunk/lib/cpp/src/concurrency/BoostThreadFactory.cpp
* /thrift/trunk/lib/cpp/src/concurrency/BoostThreadFactory.h
* /thrift/trunk/lib/cpp/src/concurrency/Exception.h
* /thrift/trunk/lib/cpp/src/concurrency/FunctionRunner.h
* /thrift/trunk/lib/cpp/src/concurrency/Monitor.cpp
* /thrift/trunk/lib/cpp/src/concurrency/Monitor.h
* /thrift/trunk/lib/cpp/src/concurrency/Mutex.cpp
* /thrift/trunk/lib/cpp/src/concurrency/Mutex.h
* /thrift/trunk/lib/cpp/src/concurrency/PlatformThreadFactory.h
* /thrift/trunk/lib/cpp/src/concurrency/PosixThreadFactory.cpp
* /thrift/trunk/lib/cpp/src/concurrency/PosixThreadFactory.h
* /thrift/trunk/lib/cpp/src/concurrency/Thread.h
* /thrift/trunk/lib/cpp/src/concurrency/ThreadManager.cpp
* /thrift/trunk/lib/cpp/src/concurrency/ThreadManager.h
* /thrift/trunk/lib/cpp/src/concurrency/TimerManager.cpp
* /thrift/trunk/lib/cpp/src/concurrency/TimerManager.h
* /thrift/trunk/lib/cpp/src/concurrency/Util.cpp
* /thrift/trunk/lib/cpp/src/concurrency/Util.h
* /thrift/trunk/lib/cpp/src/concurrency/test/Tests.cpp
* /thrift/trunk/lib/cpp/src/concurrency/test/ThreadFactoryTests.h
* /thrift/trunk/lib/cpp/src/concurrency/test/ThreadManagerTests.h
* /thrift/trunk/lib/cpp/src/concurrency/test/TimerManagerTests.h
* /thrift/trunk/lib/cpp/src/processor/PeekProcessor.cpp
* /thrift/trunk/lib/cpp/src/processor/PeekProcessor.h
* /thrift/trunk/lib/cpp/src/processor/StatsProcessor.h
* /thrift/trunk/lib/cpp/src/protocol/TBase64Utils.cpp
* /thrift/trunk/lib/cpp/src/protocol/TBase64Utils.h
* /thrift/trunk/lib/cpp/src/protocol/TBinaryProtocol.h
* /thrift/trunk/lib/cpp/src/protocol/TBinaryProtocol.tcc
* /thrift/trunk/lib/cpp/src/protocol/TCompactProtocol.h
* /thrift/trunk/lib/cpp/src/protocol/TCompactProtocol.tcc
* /thrift/trunk/lib/cpp/src/protocol/TDebugProtocol.cpp
* /thrift/trunk/lib/cpp/src/protocol/TDebugProtocol.h
* /thrift/trunk/lib/cpp/src/protocol/TDenseProtocol.cpp
* /thrift/trunk/lib/cpp/src/protocol/TDenseProtocol.h
* /thrift/trunk/lib/cpp/src/protocol/TJSONProtocol.cpp
* /thrift/trunk/lib/cpp/src/protocol/TJSONProtocol.h
* /thrift/trunk/lib/cpp/src/protocol/TProtocol.h
* /thrift/trunk/lib/cpp/src/protocol/TProtocolException.h
* /thrift/trunk/lib/cpp/src/protocol/TProtocolTap.h
* /thrift/trunk/lib/cpp/src/protocol/TVirtualProtocol.h
* /thrift/trunk/lib/cpp/src/qt/TQIODeviceTransport.cpp
* /thrift/trunk/lib/cpp/src/qt/TQIODeviceTransport.h
* /thrift/trunk/lib/cpp/src/qt/TQTcpServer.cpp
* /thrift/trunk/lib/cpp/src/qt/TQTcpServer.h
* /thrift/trunk/lib/cpp/src/server/TNonblockingServer.cpp
* /thrift/trunk/lib/cpp/src/server/TNonblockingServer.h
* /thrift/trunk/lib/cpp/src/server/TServer.cpp
* /thrift/trunk/lib/cpp/src/server/TServer.h
* /thrift/trunk/lib/cpp/src/server/TSimpleServer.cpp
* /thrift/trunk/lib/cpp/src/server/TSimpleServer.h
* /thrift/trunk/lib/cpp/src/server/TThreadPoolServer.cpp
* /thrift/trunk/lib/cpp/src/server/TThreadPoolServer.h
* /thrift/trunk/lib/cpp/src/server/TThreadedServer.cpp
* /thrift/trunk/lib/cpp/src/server/TThreadedServer.h
* /thrift/trunk/lib/cpp/src/thrift
* /thrift/trunk/lib/cpp/src/thrift/TApplicationException.cpp
* /thrift/trunk/lib/cpp/src/thrift/TApplicationException.h
* /thrift/trunk/lib/cpp/src/thrift/TDispatchProcessor.h
* /thrift/trunk/lib/cpp/src/thrift/TLogging.h
* /thrift/trunk/lib/cpp/src/thrift/TProcessor.h
* /thrift/trunk/lib/cpp/src/thrift/TReflectionLocal.h
* /thrift/trunk/lib/cpp/src/thrift/Thrift.cpp
* /thrift/trunk/lib/cpp/src/thrift/Thrift.h
* /thrift/trunk/lib/cpp/src/thrift/VirtualProfiling.cpp
* /thrift/trunk/lib/cpp/src/thrift/async
* /thrift/trunk/lib/cpp/src/thrift/async/TAsyncBufferProcessor.h
* /thrift/trunk/lib/cpp/src/thrift/async/TAsyncChannel.cpp
* /thrift/trunk/lib/cpp/src/thrift/async/TAsyncChannel.h
* /thrift/trunk/lib/cpp/src/thrift/async/TAsyncDispatchProcessor.h
* /thrift/trunk/lib/cpp/src/thrift/async/TAsyncProcessor.h
* /thrift/trunk/lib/cpp/src/thrift/async/TAsyncProtocolProcessor.cpp
* /thrift/trunk/lib/cpp/src/thrift/async/TAsyncProtocolProcessor.h
* /thrift/trunk/lib/cpp/src/thrift/async/TEvhttpClientChannel.cpp
* /thrift/trunk/lib/cpp/src/thrift/async/TEvhttpClientChannel.h
* /thrift/trunk/lib/cpp/src/thrift/async/TEvhttpServer.cpp
* /thrift/trunk/lib/cpp/src/thrift/async/TEvhttpServer.h
* /thrift/trunk/lib/cpp/src/thrift/concurrency
* /thrift/trunk/lib/cpp/src/thrift/concurrency/BoostMonitor.cpp
* /thrift/trunk/lib/cpp/src/thrift/concurrency/BoostMutex.cpp
* /thrift/trunk/lib/cpp/src/thrift/concurrency/BoostThreadFactory.cpp
* /thrift/trunk/lib/cpp/src/thrift/concurrency/BoostThreadFactory.h
* /thrift/trunk/lib/cpp/src/thrift/concurrency/Exception.h
* /thrift/trunk/lib/cpp/src/thrift/concurrency/FunctionRunner.h
* /thrift/trunk/lib/cpp/src/thrift/concurrency/Monitor.cpp
* /thrift/trunk/lib/cpp/src/thrift/concurrency/Monitor.h
* /thrift/trunk/lib/cpp/src/thrift/concurrency/Mutex.cpp
* /thrift/trunk/lib/cpp/src/thrift/concurrency/Mutex.h
* /thrift/trunk/lib/cpp/src/thrift/concurrency/PlatformThreadFactory.h
* /thrift/trunk/lib/cpp/src/thrift/concurrency/PosixThreadFactory.cpp
* /thrift/trunk/lib/cpp/src/thrift/concurrency/PosixThreadFactory.h
* /thrift/trunk/lib/cpp/src/thrift/concurrency/Thread.h
* /thrift/trunk/lib/cpp/src/thrift/concurrency/ThreadManager.cpp
* /thrift/trunk/lib/cpp/src/thrift/concurrency/ThreadManager.h
* /thrift/trunk/lib/cpp/src/thrift/concurrency/TimerManager.cpp
* /thrift/trunk/lib/cpp/src/thrift/concurrency/TimerManager.h
* /thrift/trunk/lib/cpp/src/thrift/concurrency/Util.cpp
* /thrift/trunk/lib/cpp/src/thrift/concurrency/Util.h
* /thrift/trunk/lib/cpp/src/thrift/concurrency/test
* /thrift/trunk/lib/cpp/src/thrift/concurrency/test/Tests.cpp
* /thrift/trunk/lib/cpp/src/thrift/concurrency/test/ThreadFactoryTests.h
* /thrift/trunk/lib/cpp/src/thrift/concurrency/test/ThreadManagerTests.h
* /thrift/trunk/lib/cpp/src/thrift/concurrency/test/TimerManagerTests.h
* /thrift/trunk/lib/cpp/src/thrift/processor
* /thrift/trunk/lib/cpp/src/thrift/processor/PeekProcessor.cpp
* /thrift/trunk/lib/cpp/src/thrift/processor/PeekProcessor.h
* /thrift/trunk/lib/cpp/src/thrift/processor/StatsProcessor.h
* /thrift/trunk/lib/cpp/src/thrift/protocol
* /thrift/trunk/lib/cpp/src/thrift/protocol/TBase64Utils.cpp
* /thrift/trunk/lib/cpp/src/thrift/protocol/TBase64Utils.h
* /thrift/trunk/lib/cpp/src/thrift/protocol/TBinaryProtocol.h
* /thrift/trunk/lib/cpp/src/thrift/protocol/TBinaryProtocol.tcc
* /thrift/trunk/lib/cpp/src/thrift/protocol/TCompactProtocol.h
* /thrift/trunk/lib/cpp/src/thrift/protocol/TCompactProtocol.tcc
* /thrift/trunk/lib/cpp/src/thrift/protocol/TDebugProtocol.cpp
* /thrift/trunk/lib/cpp/src/thrift/protocol/TDebugProtocol.h
* /thrift/trunk/lib/cpp/src/thrift/protocol/TDenseProtocol.cpp
* /thrift/trunk/lib/cpp/src/thrift/protocol/TDenseProtocol.h
* /thrift/trunk/lib/cpp/src/thrift/protocol/TJSONProtocol.cpp
* /thrift/trunk/lib/cpp/src/thrift/protocol/TJSONProtocol.h
* /thrift/trunk/lib/cpp/src/thrift/protocol/TProtocol.h
* /thrift/trunk/lib/cpp/src/thrift/protocol/TProtocolException.h
* /thrift/trunk/lib/cpp/src/thrift/protocol/TProtocolTap.h
* /thrift/trunk/lib/cpp/src/thrift/protocol/TVirtualProtocol.h
* /thrift/trunk/lib/cpp/src/thrift/qt
* /thrift/trunk/lib/cpp/src/thrift/qt/TQIODeviceTransport.cpp
* /thrift/trunk/lib/cpp/src/thrift/qt/TQIODeviceTransport.h
* /thrift/trunk/lib/cpp/src/thrift/qt/TQTcpServer.cpp
* /thrift/trunk/lib/cpp/src/thrift/qt/TQTcpServer.h
* /thrift/trunk/lib/cpp/src/thrift/server
* /thrift/trunk/lib/cpp/src/thrift/server/TNonblockingServer.cpp
* /thrift/trunk/lib/cpp/src/thrift/server/TNonblockingServer.h
* /thrift/trunk/lib/cpp/src/thrift/server/TServer.cpp
* /thrift/trunk/lib/cpp/src/thrift/server/TServer.h
* /thrift/trunk/lib/cpp/src/thrift/server/TSimpleServer.cpp
* /thrift/trunk/lib/cpp/src/thrift/server/TSimpleServer.h
* /thrift/trunk/lib/cpp/src/thrift/server/TThreadPoolServer.cpp
* /thrift/trunk/lib/cpp/src/thrift/server/TThreadPoolServer.h
* /thrift/trunk/lib/cpp/src/thrift/server/TThreadedServer.cpp
* /thrift/trunk/lib/cpp/src/thrift/server/TThreadedServer.h
* /thrift/trunk/lib/cpp/src/thrift/transport
* /thrift/trunk/lib/cpp/src/thrift/transport/TBufferTransports.cpp
* /thrift/trunk/lib/cpp/src/thrift/transport/TBufferTransports.h
* /thrift/trunk/lib/cpp/src/thrift/transport/TFDTransport.cpp
* /thrift/trunk/lib/cpp/src/thrift/transport/TFDTransport.h
* /thrift/trunk/lib/cpp/src/thrift/transport/TFileTransport.cpp
* /thrift/trunk/lib/cpp/src/thrift/transport/TFileTransport.h
* /thrift/trunk/lib/cpp/src/thrift/transport/THttpClient.cpp
* /thrift/trunk/lib/cpp/src/thrift/transport/THttpClient.h
* /thrift/trunk/lib/cpp/src/thrift/transport/THttpServer.cpp
* /thrift/trunk/lib/cpp/src/thrift/transport/THttpServer.h
* /thrift/trunk/lib/cpp/src/thrift/transport/THttpTransport.cpp
* /thrift/trunk/lib/cpp/src/thrift/transport/THttpTransport.h
* /thrift/trunk/lib/cpp/src/thrift/transport/TSSLServerSocket.cpp
* /thrift/trunk/lib/cpp/src/thrift/transport/TSSLServerSocket.h
* /thrift/trunk/lib/cpp/src/thrift/transport/TSSLSocket.cpp
* /thrift/trunk/lib/cpp/src/thrift/transport/TSSLSocket.h
* /thrift/trunk/lib/cpp/src/thrift/transport/TServerSocket.cpp
* /thrift/trunk/lib/cpp/src/thrift/transport/TServerSocket.h
* /thrift/trunk/lib/cpp/src/thrift/transport/TServerTransport.h
* /thrift/trunk/lib/cpp/src/thrift/transport/TShortReadTransport.h
* /thrift/trunk/lib/cpp/src/thrift/transport/TSimpleFileTransport.cpp
* /thrift/trunk/lib/cpp/src/thrift/transport/TSimpleFileTransport.h
* /thrift/trunk/lib/cpp/src/thrift/transport/TSocket.cpp
* /thrift/trunk/lib/cpp/src/thrift/transport/TSocket.h
* /thrift/trunk/lib/cpp/src/thrift/transport/TSocketPool.cpp
* /thrift/trunk/lib/cpp/src/thrift/transport/TSocketPool.h
* /thrift/trunk/lib/cpp/src/thrift/transport/TTransport.h
* /thrift/trunk/lib/cpp/src/thrift/transport/TTransportException.cpp
* /thrift/trunk/lib/cpp/src/thrift/transport/TTransportException.h
* /thrift/trunk/lib/cpp/src/thrift/transport/TTransportUtils.cpp
* /thrift/trunk/lib/cpp/src/thrift/transport/TTransportUtils.h
* /thrift/trunk/lib/cpp/src/thrift/transport/TVirtualTransport.h
* /thrift/trunk/lib/cpp/src/thrift/transport/TZlibTransport.cpp
* /thrift/trunk/lib/cpp/src/thrift/transport/TZlibTransport.h
* /thrift/trunk/lib/cpp/src/thrift/windows
* /thrift/trunk/lib/cpp/src/thrift/windows/GetTimeOfDay.cpp
* /thrift/trunk/lib/cpp/src/thrift/windows/GetTimeOfDay.h
* /thrift/trunk/lib/cpp/src/thrift/windows/Operators.h
* /thrift/trunk/lib/cpp/src/thrift/windows/SocketPair.cpp
* /thrift/trunk/lib/cpp/src/thrift/windows/SocketPair.h
* /thrift/trunk/lib/cpp/src/thrift/windows/StdAfx.cpp
* /thrift/trunk/lib/cpp/src/thrift/windows/StdAfx.h
* /thrift/trunk/lib/cpp/src/thrift/windows/TWinsockSingleton.cpp
* /thrift/trunk/lib/cpp/src/thrift/windows/TWinsockSingleton.h
* /thrift/trunk/lib/cpp/src/thrift/windows/TargetVersion.h
* /thrift/trunk/lib/cpp/src/thrift/windows/WinFcntl.cpp
* /thrift/trunk/lib/cpp/src/thrift/windows/WinFcntl.h
* /thrift/trunk/lib/cpp/src/thrift/windows/config.h
* /thrift/trunk/lib/cpp/src/thrift/windows/force_inc.h
* /thrift/trunk/lib/cpp/src/thrift/windows/tr1
* /thrift/trunk/lib/cpp/src/thrift/windows/tr1/functional
* /thrift/trunk/lib/cpp/src/transport/TBufferTransports.cpp
* /thrift/trunk/lib/cpp/src/transport/TBufferTransports.h
* /thrift/trunk/lib/cpp/src/transport/TFDTransport.cpp
* /thrift/trunk/lib/cpp/src/transport/TFDTransport.h
* /thrift/trunk/lib/cpp/src/transport/TFileTransport.cpp
* /thrift/trunk/lib/cpp/src/transport/TFileTransport.h
* /thrift/trunk/lib/cpp/src/transport/THttpClient.cpp
* /thrift/trunk/lib/cpp/src/transport/THttpClient.h
* /thrift/trunk/lib/cpp/src/transport/THttpServer.cpp
* /thrift/trunk/lib/cpp/src/transport/THttpServer.h
* /thrift/trunk/lib/cpp/src/transport/THttpTransport.cpp
* /thrift/trunk/lib/cpp/src/transport/THttpTransport.h
* /thrift/trunk/lib/cpp/src/transport/TPipe.cpp
* /thrift/trunk/lib/cpp/src/transport/TPipe.h
* /thrift/trunk/lib/cpp/src/transport/TPipeServer.cpp
* /thrift/trunk/lib/cpp/src/transport/TPipeServer.h
* /thrift/trunk/lib/cpp/src/transport/TSSLServerSocket.cpp
* /thrift/trunk/lib/cpp/src/transport/TSSLServerSocket.h
* /thrift/trunk/lib/cpp/src/transport/TSSLSocket.cpp
* /thrift/trunk/lib/cpp/src/transport/TSSLSocket.h
* /thrift/trunk/lib/cpp/src/transport/TServerSocket.cpp
* /thrift/trunk/lib/cpp/src/transport/TServerSocket.h
* /thrift/trunk/lib/cpp/src/transport/TServerTransport.h
* /thrift/trunk/lib/cpp/src/transport/TShortReadTransport.h
* /thrift/trunk/lib/cpp/src/transport/TSimpleFileTransport.cpp
* /thrift/trunk/lib/cpp/src/transport/TSimpleFileTransport.h
* /thrift/trunk/lib/cpp/src/transport/TSocket.cpp
* /thrift/trunk/lib/cpp/src/transport/TSocket.h
* /thrift/trunk/lib/cpp/src/transport/TSocketPool.cpp
* /thrift/trunk/lib/cpp/src/transport/TSocketPool.h
* /thrift/trunk/lib/cpp/src/transport/TTransport.h
* /thrift/trunk/lib/cpp/src/transport/TTransportException.cpp
* /thrift/trunk/lib/cpp/src/transport/TTransportException.h
* /thrift/trunk/lib/cpp/src/transport/TTransportUtils.cpp
* /thrift/trunk/lib/cpp/src/transport/TTransportUtils.h
* /thrift/trunk/lib/cpp/src/transport/TVirtualTransport.h
* /thrift/trunk/lib/cpp/src/transport/TZlibTransport.cpp
* /thrift/trunk/lib/cpp/src/transport/TZlibTransport.h
* /thrift/trunk/lib/cpp/src/windows/GetTimeOfDay.cpp
* /thrift/trunk/lib/cpp/src/windows/GetTimeOfDay.h
* /thrift/trunk/lib/cpp/src/windows/Operators.h
* /thrift/trunk/lib/cpp/src/windows/SocketPair.cpp
* /thrift/trunk/lib/cpp/src/windows/SocketPair.h
* /thrift/trunk/lib/cpp/src/windows/StdAfx.cpp
* /thrift/trunk/lib/cpp/src/windows/StdAfx.h
* /thrift/trunk/lib/cpp/src/windows/TWinsockSingleton.cpp
* /thrift/trunk/lib/cpp/src/windows/TWinsockSingleton.h
* /thrift/trunk/lib/cpp/src/windows/TargetVersion.h
* /thrift/trunk/lib/cpp/src/windows/WinFcntl.cpp
* /thrift/trunk/lib/cpp/src/windows/WinFcntl.h
* /thrift/trunk/lib/cpp/src/windows/config.h
* /thrift/trunk/lib/cpp/src/windows/force_inc.h
* /thrift/trunk/lib/cpp/src/windows/tr1/functional
* /thrift/trunk/lib/cpp/test/AllProtocolTests.cpp
* /thrift/trunk/lib/cpp/test/AllProtocolTests.tcc
* /thrift/trunk/lib/cpp/test/Benchmark.cpp
* /thrift/trunk/lib/cpp/test/DebugProtoTest.cpp
* /thrift/trunk/lib/cpp/test/DenseProtoTest.cpp
* /thrift/trunk/lib/cpp/test/GenericHelpers.h
* /thrift/trunk/lib/cpp/test/JSONProtoTest.cpp
* /thrift/trunk/lib/cpp/test/OptionalRequiredTest.cpp
* /thrift/trunk/lib/cpp/test/RWMutexStarveTest.cpp
* /thrift/trunk/lib/cpp/test/SpecializationTest.cpp
* /thrift/trunk/lib/cpp/test/TBufferBaseTest.cpp
* /thrift/trunk/lib/cpp/test/TFDTransportTest.cpp
* /thrift/trunk/lib/cpp/test/TFileTransportTest.cpp
* /thrift/trunk/lib/cpp/test/TMemoryBufferTest.cpp
* /thrift/trunk/lib/cpp/test/TPipedTransportTest.cpp
* /thrift/trunk/lib/cpp/test/ThriftTest_extras.cpp
* /thrift/trunk/lib/cpp/test/TransportTest.cpp
* /thrift/trunk/lib/cpp/test/ZlibTest.cpp
* /thrift/trunk/test/cpp/src/StressTest.cpp
* /thrift/trunk/test/cpp/src/StressTestNonBlocking.cpp
* /thrift/trunk/test/cpp/src/TestClient.cpp
* /thrift/trunk/test/cpp/src/TestServer.cpp
* /thrift/trunk/test/threads/ThreadsClient.cpp
* /thrift/trunk/test/threads/ThreadsServer.cpp
* /thrift/trunk/tutorial/cpp/CppClient.cpp
* /thrift/trunk/tutorial/cpp/CppServer.cpp
> Thrift (cpp) include files shouldn't require adding "thrift" to the compilers
> include path.
> -------------------------------------------------------------------------------------------
>
> Key: THRIFT-1552
> URL: https://issues.apache.org/jira/browse/THRIFT-1552
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Compiler, C++ - Library
> Affects Versions: 0.8
> Environment: All
> Reporter: Ricky Cormier
> Assignee: Ricky Cormier
> Labels: cpp, include, path
> Attachments:
> THRIFT-1552-Include-paths-for-c-and-cpp-should-be-prefixed-with-thrift.patch,
> THRIFT-1552-Include-paths-for-c-and-cpp-should-be-prefixed-with-thrift.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> When including thrift header files it is necessary to add thrift to the
> compilers include path. Headers are then included something like this...
> #include <thrift.h>
> #include <server/TNonblockingServer.h>
> #include <protocol/TBinaryProtocol.h>
> ... and so on.
> It is generally preferable to have include paths prefixed with the name of
> the library to which they belong. This not only prevents the possibility of
> include ambiguity it also acts as documentations and aids readability.
> This changes is to allow the header files to be included with "thrift" as the
> leading path leaf...
> #include <thrift/thrift.h>
> #include <thrift/server/TNonblockingServer.h>
> #include <thrift/protocol/TBinaryProtocol.h>
> We have already made this change to our version of thrift-0.5.0 and I am
> currently working on patching this change to trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
