[ https://issues.apache.org/jira/browse/THRIFT-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254089#comment-13254089 ]
Hudson commented on THRIFT-1552: -------------------------------- Integrated in Thrift #439 (See [https://builds.apache.org/job/Thrift/439/]) THRIFT-1552 Thrift (cpp) include files shouldn't require adding "thrift" to the compilers include path Some additional fixes to build it on windows as well Patch: Benoit Dion and Roger Meier (Revision 1326087) Result = SUCCESS roger : http://svn.apache.org/viewvc/?view=rev&rev=1326087 Files : * /thrift/trunk/lib/cpp/libthrift.vcxproj * /thrift/trunk/lib/cpp/libthriftnb.vcxproj * /thrift/trunk/lib/cpp/src/thrift/async/TAsyncChannel.cpp * /thrift/trunk/lib/cpp/src/thrift/async/TAsyncChannel.h * /thrift/trunk/lib/cpp/src/thrift/concurrency/ThreadManager.h * /thrift/trunk/lib/cpp/src/thrift/protocol/TDenseProtocol.cpp * /thrift/trunk/lib/cpp/src/thrift/transport/TTransportException.cpp > Thrift (cpp) include files shouldn't require adding "thrift" to the compilers > include path. > ------------------------------------------------------------------------------------------- > > Key: THRIFT-1552 > URL: https://issues.apache.org/jira/browse/THRIFT-1552 > Project: Thrift > Issue Type: Improvement > Components: C++ - Compiler, C++ - Library > Affects Versions: 0.8 > Environment: All > Reporter: Ricky Cormier > Assignee: Ricky Cormier > Labels: cpp, include, path > Attachments: > THRIFT-1552-Include-paths-for-c-and-cpp-should-be-prefixed-with-thrift.patch, > THRIFT-1552-Include-paths-for-c-and-cpp-should-be-prefixed-with-thrift.patch > > Original Estimate: 48h > Remaining Estimate: 48h > > When including thrift header files it is necessary to add thrift to the > compilers include path. Headers are then included something like this... > #include <thrift.h> > #include <server/TNonblockingServer.h> > #include <protocol/TBinaryProtocol.h> > ... and so on. > It is generally preferable to have include paths prefixed with the name of > the library to which they belong. This not only prevents the possibility of > include ambiguity it also acts as documentations and aids readability. > This changes is to allow the header files to be included with "thrift" as the > leading path leaf... > #include <thrift/thrift.h> > #include <thrift/server/TNonblockingServer.h> > #include <thrift/protocol/TBinaryProtocol.h> > We have already made this change to our version of thrift-0.5.0 and I am > currently working on patching this change to trunk. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira