[ 
https://issues.apache.org/jira/browse/THRIFT-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409774#comment-13409774
 ] 

Nick Zalabak edited comment on THRIFT-1629 at 7/9/12 7:47 PM:
--------------------------------------------------------------

I didn't see any comment on the pull request I submitted. The pull request 
removes Mongrel entirely, replaces it with Thin, which is compatible with Ruby 
1.8 and 1.9. This would eliminate the problem during configuring, making, and 
installing and the --pre flag. 

I also don't understand how it is marked as not a problem if developers aren't 
able to simply grab the latest stable copy of Thrift and compile and test it 
successfully without additional complexities of compiler and dependency hacks. 
The Ruby client shouldn't specify an abandoned dependency, namely Mongrel, that 
no longer has an active maintainer.  

https://github.com/apache/thrift/pull/23 
                
      was (Author: techwhizbang):
    I didn't see any comment on the pull request I submitted. The pull request 
removes Mongrel entirely, replaces it with Thin, a more modern Ruby web server 
that is compatible with Ruby 1.8 and 1.9. This would eliminate the problem 
during configuring, making, and installing. 

https://github.com/apache/thrift/pull/23 
                  
> Ruby 1.9 Compatibility during Thrift configure, make, install
> -------------------------------------------------------------
>
>                 Key: THRIFT-1629
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1629
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Ruby - Library
>    Affects Versions: 0.8
>         Environment: Mac OSX, *nix
>            Reporter: Nick Zalabak
>
> I downloaded the 0.8 stable version of Thrift and began by performing the 
> configure, make tasks. It appears that this version of Thrift is not 
> compatible with Ruby 1.9.
> The problem encountered is that Ruby library inside Thrift includes the 
> Mongrel web server. Mongrel does not work with Ruby 1.9. A drop in 
> replacement for Mongrel is the Thin web server, and there are also several 
> other choices. 
> I have submitted a pull request via Github to resolve this matter. 
> https://github.com/apache/thrift/pull/23
> Thanks.
> Nick Zalabak
> @techwhizbang

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to