[
https://issues.apache.org/jira/browse/THRIFT-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410416#comment-13410416
]
Jake Farrell commented on THRIFT-1629:
--------------------------------------
Nick, we do not currently accept github pull requests, please see
http://thrift.apache.org/docs/HowToContribute/ for information on submitting a
patch. Also your patch isn't against trunk which shows the dependencies as the
following
s.add_development_dependency "rake"
s.add_development_dependency "rspec", "1.3.2"
s.add_development_dependency "mongrel"
vs your patch which has
s.add_development_dependency "rake", "~> 0.9.2.2"
s.add_development_dependency "rspec", "1.3.2"
s.add_development_dependency "rack", "~> 1.4.1"
s.add_development_dependency "rack-test", "~> 0.6.1"
s.add_development_dependency "thin", "~> 1.3.1"
s.add_development_dependency "bundler", "~> 1.1.4"
I am all for using the best option for maintainability and cross version
stability, but I would like to avoid adding more dependencies to help keep
things easier to debug.
> Ruby 1.9 Compatibility during Thrift configure, make, install
> -------------------------------------------------------------
>
> Key: THRIFT-1629
> URL: https://issues.apache.org/jira/browse/THRIFT-1629
> Project: Thrift
> Issue Type: Improvement
> Components: Ruby - Library
> Affects Versions: 0.8
> Environment: Mac OSX, *nix
> Reporter: Nick Zalabak
>
> I downloaded the 0.8 stable version of Thrift and began by performing the
> configure, make tasks. It appears that this version of Thrift is not
> compatible with Ruby 1.9.
> The problem encountered is that Ruby library inside Thrift includes the
> Mongrel web server. Mongrel does not work with Ruby 1.9. A drop in
> replacement for Mongrel is the Thin web server, and there are also several
> other choices.
> I have submitted a pull request via Github to resolve this matter.
> https://github.com/apache/thrift/pull/23
> Thanks.
> Nick Zalabak
> @techwhizbang
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
