[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411300#comment-13411300 ]
Henrique Mendonca commented on THRIFT-1353: ------------------------------------------- Not really, just wanted to facilitate it for the committers and testers. Talked briefly to Roger before but I wasn't sure whether Jenkins would handle the NPM. We can definitely leave the files from node-int64 uncommitted if it works. Thanks for having a look anyways! > Switch to performance branch, get rid of BinaryParser > ----------------------------------------------------- > > Key: THRIFT-1353 > URL: https://issues.apache.org/jira/browse/THRIFT-1353 > Project: Thrift > Issue Type: Improvement > Components: Node.js - Library > Affects Versions: 0.7 > Reporter: Hans Duedal > Assignee: Roger Meier > Labels: node, nodejs > Fix For: 1.0 > > Attachments: THRIFT-1353-noBinaryParser-BufferedTrans-Int64-v3.patch > > > I vote that the thrift library switches to the performance branch at > https://github.com/wadey/node-thrift/tree/performance > I much prefer using the node.js buffers over the BinaryParser class, the > performance branch seems focused on this very issue. Also it includes the > excellent int64 implementation from broofa. What's not to like? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira