[ 
https://issues.apache.org/jira/browse/THRIFT-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527543#comment-13527543
 ] 

Carl Yeksigian commented on THRIFT-1782:
----------------------------------------

I've attached v2 which does not break old versions -- it will continue to 
generate #if SILVERLIGHT if async is not requested (for example, to target .NET 
2). I didn't inspect the changes and your comment enough to understand what you 
were pointing out Henrique; thanks for bringing it to my attention!

Now, if you specify async, it will not generate the #if statements. Also, this 
patch should apply (sorry Jens!).
                
> async only defined in silverlight
> ---------------------------------
>
>                 Key: THRIFT-1782
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1782
>             Project: Thrift
>          Issue Type: Bug
>          Components: C# - Compiler
>    Affects Versions: 0.9
>            Reporter: Carl Yeksigian
>             Fix For: 1.0
>
>         Attachments: 1782.txt, 1782-v2.patch
>
>
> The async pattern is available in C# 5 on .NET 4.5. Thus, it shouldn't only 
> be for Silverlight.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to