[ 
https://issues.apache.org/jira/browse/THRIFT-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539753#comment-13539753
 ] 

Nathan Beyer commented on THRIFT-1766:
--------------------------------------

{quote}Roger Meier added a comment - 26/Dec/12 16:45
Could you provide some patches to integrate ruby into the cross language test 
suite(THRIFT-847)?
We use test/test.sh to test across languages such as 
cpp+java+py+js+nodejs.{quote}

I thought the Ruby library was already participating in this. There's already 
some external tests reference in the Rake commands, but perhaps those are for 
something else (compiler tests?).

Are these the tests you're referring to: 
https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=tree;f=test/rb;h=c9e42987ef18bb61285298d82d8ef5f5d59bc77e;hb=HEAD

Are you just asking for some additional test cases? Either way, should that 
work happen on this issue or on THRIFT-847? I'd prefer to do it on THRIFT-847 
or a new issue, if you don't mind.
                
> [Ruby] Provide support for binary types
> ---------------------------------------
>
>                 Key: THRIFT-1766
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1766
>             Project: Thrift
>          Issue Type: Bug
>          Components: Ruby - Library
>    Affects Versions: 0.9
>            Reporter: Nathan Beyer
>         Attachments: THRIFT-1766-provide-support-for-binary-types.patch
>
>
> The Ruby library didn't provide explicit support for 'binary' types, which 
> sort of worked on Ruby 1.8.7 and with Thrift 0.8, but it doesn't work with 
> Ruby 1.9.3 and the encoding changes that were included with Thrift 0.9.
> This issue is intended to provide first class support for the 'binary' type.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to