[
https://issues.apache.org/jira/browse/THRIFT-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551055#comment-13551055
]
Hudson commented on THRIFT-1826:
--------------------------------
Integrated in Thrift #612 (See [https://builds.apache.org/job/Thrift/612/])
THRIFT-1826 update c_glib source header paths (Revision
e3da768367d0a3e013a00a5a365e58aed3bffa32)
Result = FAILURE
roger :
https://git-wip-us.apache.org/repos/asf?p=thrift.git&a=commit&h=e3da768367d0a3e013a00a5a365e58aed3bffa32
Files :
* lib/c_glib/test/testsimpleserver.c
* lib/c_glib/src/thrift/server/thrift_server.c
* lib/c_glib/src/thrift/c_glib/transport/thrift_transport_factory.c
* lib/c_glib/src/thrift/transport/thrift_buffered_transport.c
* lib/c_glib/test/testbufferedtransport.c
* lib/c_glib/src/thrift/c_glib/protocol/thrift_protocol_factory.h
* lib/c_glib/src/thrift/thrift_struct.h
* lib/c_glib/src/thrift/c_glib/server/thrift_server.h
* lib/c_glib/src/thrift/thrift.h
* lib/c_glib/src/thrift/protocol/thrift_protocol.h
* lib/c_glib/src/thrift/c_glib/server/thrift_simple_server.h
* lib/c_glib/src/thrift/c_glib/thrift.c
* lib/c_glib/src/thrift/server/thrift_simple_server.c
* lib/c_glib/src/thrift/c_glib/thrift_struct.c
* lib/c_glib/src/thrift/c_glib/protocol/thrift_protocol.c
* lib/c_glib/src/thrift/c_glib/transport/thrift_server_transport.c
* lib/c_glib/src/thrift/c_glib/protocol/thrift_binary_protocol.c
* lib/c_glib/src/thrift/c_glib/transport/thrift_server_transport.h
* lib/c_glib/src/thrift/c_glib/transport/thrift_framed_transport.c
* lib/c_glib/src/thrift/c_glib/transport/thrift_buffered_transport.c
* lib/c_glib/test/teststruct.c
* lib/c_glib/src/thrift/c_glib/server/thrift_simple_server.c
* lib/c_glib/src/thrift/c_glib/transport/thrift_memory_buffer.h
* lib/c_glib/src/thrift/server/thrift_server.h
* compiler/cpp/src/generate/t_c_glib_generator.cc
* lib/c_glib/test/testmemorybuffer.c
* lib/c_glib/src/thrift/c_glib/transport/thrift_server_socket.h
* lib/c_glib/src/thrift/server/thrift_simple_server.h
* lib/c_glib/src/thrift/c_glib/protocol/thrift_protocol_factory.c
* lib/c_glib/src/thrift/c_glib/transport/thrift_buffered_transport.h
* lib/c_glib/src/thrift/transport/thrift_framed_transport.h
* lib/c_glib/src/thrift/protocol/thrift_binary_protocol.h
* lib/c_glib/src/thrift/protocol/thrift_protocol_factory.c
* lib/c_glib/src/thrift/c_glib/protocol/thrift_binary_protocol.h
* lib/c_glib/src/thrift/transport/thrift_transport_factory.h
* lib/c_glib/src/thrift/c_glib/thrift_application_exception.h
* lib/c_glib/src/thrift/thrift_struct.c
* lib/c_glib/src/thrift/transport/thrift_transport_factory.c
* lib/c_glib/src/thrift/transport/thrift_socket.h
* lib/c_glib/src/thrift/transport/thrift_server_transport.h
* lib/c_glib/src/thrift/c_glib/thrift.h
* lib/c_glib/src/thrift/c_glib/processor/thrift_processor.h
* lib/c_glib/test/testtransportsocket.c
* lib/c_glib/src/thrift/transport/thrift_transport.c
* lib/c_glib/src/thrift/c_glib/thrift_application_exception.c
* lib/c_glib/src/thrift/protocol/thrift_protocol_factory.h
* lib/c_glib/src/thrift/transport/thrift_transport.h
* lib/c_glib/test/testthrifttest.c
* lib/c_glib/src/thrift/c_glib/transport/thrift_transport.c
* lib/c_glib/src/thrift/processor/thrift_processor.h
* lib/c_glib/src/thrift/c_glib/transport/thrift_socket.c
* lib/c_glib/src/thrift/transport/thrift_server_socket.c
* lib/c_glib/src/thrift/transport/thrift_memory_buffer.h
* lib/c_glib/src/thrift/protocol/thrift_binary_protocol_factory.c
* lib/c_glib/src/thrift/transport/thrift_socket.c
* lib/c_glib/src/thrift/c_glib/protocol/thrift_protocol.h
* lib/c_glib/src/thrift/c_glib/transport/thrift_server_socket.c
* lib/c_glib/src/thrift/protocol/thrift_protocol.c
* lib/c_glib/src/thrift/protocol/thrift_binary_protocol.c
* lib/c_glib/src/thrift/transport/thrift_memory_buffer.c
* lib/c_glib/src/thrift/processor/thrift_processor.c
* lib/c_glib/src/thrift/protocol/thrift_binary_protocol_factory.h
* lib/c_glib/src/thrift/transport/thrift_server_transport.c
* lib/c_glib/src/thrift/c_glib/processor/thrift_processor.c
* lib/c_glib/src/thrift/c_glib/transport/thrift_transport_factory.h
* lib/c_glib/src/thrift/c_glib/transport/thrift_socket.h
* lib/c_glib/src/thrift/c_glib/protocol/thrift_binary_protocol_factory.c
* lib/c_glib/test/testframedtransport.c
* lib/c_glib/src/thrift/c_glib/protocol/thrift_binary_protocol_factory.h
* lib/c_glib/src/thrift/c_glib/transport/thrift_memory_buffer.c
* lib/c_glib/src/thrift/c_glib/transport/thrift_framed_transport.h
* lib/c_glib/src/thrift/transport/thrift_server_socket.h
* lib/c_glib/Makefile.am
* lib/c_glib/src/thrift/c_glib/transport/thrift_transport.h
* lib/c_glib/src/thrift/thrift_application_exception.c
* lib/c_glib/test/testoptionalrequired.c
* lib/c_glib/src/thrift/transport/thrift_framed_transport.c
* lib/c_glib/src/thrift/transport/thrift_buffered_transport.h
* lib/c_glib/test/testbinaryprotocol.c
* lib/c_glib/src/thrift/thrift_application_exception.h
* lib/c_glib/test/testthrifttestclient.cpp
* lib/c_glib/src/thrift/c_glib/server/thrift_server.c
* lib/c_glib/src/thrift/thrift.c
* lib/c_glib/src/thrift/c_glib/thrift_struct.h
* lib/c_glib/thrift_c_glib.pc.in
> Library, generated files use incorrect path for Thrift headers
> --------------------------------------------------------------
>
> Key: THRIFT-1826
> URL: https://issues.apache.org/jira/browse/THRIFT-1826
> Project: Thrift
> Issue Type: Bug
> Components: C glib - Compiler, C glib - Library
> Affects Versions: 0.9
> Environment: CentOS 6.3 on x86 (32-bit)
> Reporter: Simon South
> Assignee: Roger Meier
> Priority: Minor
> Attachments: thrift-1826-update-c_glib-source-header-paths.patch
>
>
> By default Thrift's header files for C+GLib are installed beneath
> /usr/local/include/thrift/c_glib. However, both files generated by Thrift's
> compiler and Thrift's own (library) header files seem to assume these are
> available at /usr/local/include/thrift.
> Consequently, by default generated files fail to compile, e.g.:
> $ make
> gcc -g -pthread -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -c -o
> main.o main.c
> In file included from gen-c_glib/hello_world.h:10,
> from main.c:4:
> gen-c_glib/hello_world_types.h:12:34: error: thrift/thrift_struct.h: No such
> file or directory
> gen-c_glib/hello_world_types.h:13:45: error:
> thrift/protocol/thrift_protocol.h: No such file or directory
> These files would actually be found at "thrift/c_glib/thrift_struct.h" and
> "thrift/c_glib/protocol/thrift_protocol.h".
> The easy workaround is to create a symbolic link, i.e.:
> $ cd /usr/local/include/thrift/c_glib
> $ ln -s . thrift
> and then add "/usr/local/include/thrift/c_glib" to the compiler's search
> path. But it seems to me a better solution would be to
> 1. Change the path of the installed header files, perhaps storing them in
> "/usr/local/include/thrift/c_glib/thrift", which would at least remove the
> need for the symbol link;
> 2. Update the library and the generator to use the correct path in #include
> statements; or
> 3. Have the installer create a symbolic link automatically.
> If there is consensus on the correct fix (I vote for the second) I can spend
> the time to implement it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
