[ https://issues.apache.org/jira/browse/THRIFT-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13662965#comment-13662965 ]
Henrique Mendonça commented on THRIFT-1973: ------------------------------------------- Yes, I see. It's probably a problem on the configuration of the c++ server then. However, I'd not commit this until we have a proper testing running on the trunk. That means making the existing test accept parameters to change the protocol and test this and the other protocols automatically. Not a big thing but I won't have time right now. Help is welcome ;) We need to fix this before 1.0, though. [~jensg]: I think the patch is for i64 and i32 > TCompactProtocol in C# lib does not serialize and deserialize negative int32 > and int64 number correctly > ------------------------------------------------------------------------------------------------------- > > Key: THRIFT-1973 > URL: https://issues.apache.org/jira/browse/THRIFT-1973 > Project: Thrift > Issue Type: Bug > Components: C# - Library > Affects Versions: 0.9, 1.0 > Environment: Windows > Reporter: Eric Ding > Labels: PatchAvailable > Fix For: 1.0 > > Attachments: thrift-1973-TCompactProtocol-Fix.patch > > > longToZigzag and ZigzagToLong in TCompactProtocol does not perform > corresponding operations to serialize and deserialize negative int32 and > int64 number correctly. Purpose to change longToZigzag from > (ulong)(((ulong)n << 1) ^ ((ulong)n >> 63)) to (ulong)(n << 1) ^ (ulong)(n >> > 63). > Will need to do same for intToZigZag. The reason is that we want arithmetic > shift not logic shift. > The test case in the project shows this, the output on server and client are > different even though client received the same number back. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira