[
https://issues.apache.org/jira/browse/THRIFT-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13672032#comment-13672032
]
Henrique Mendonça commented on THRIFT-1973:
-------------------------------------------
Hi Carl and Eric,
Thanks a lot for your patches. I'm committing Eric's patch, but not yet Carl's.
@Carl: Your test case covers it all and is a great improvement to the platform
but I didn't get why you're removing lib/csharp/test/ThriftTest/maketest.sh
since I don't see the TestServer been used anywhere else. It would be cool to
have it on the make check too and on test/test.sh, what do you think?
We could probably rewrite it into a NUnit-test but that's a different thing.
Unfortunately, I also couldn't get the new dependencies to work automatically
on Ubuntu, please see:
https://travis-ci.org/henrique/thrift/builds/7679253
and
https://github.com/henrique/thrift/blob/trunk/.travis.yml
So, I don't think it would run automatically on Jenkins, but fell free to add
this to the trunk if you work it out.
Cheers,
Henrique
> TCompactProtocol in C# lib does not serialize and deserialize negative int32
> and int64 number correctly
> -------------------------------------------------------------------------------------------------------
>
> Key: THRIFT-1973
> URL: https://issues.apache.org/jira/browse/THRIFT-1973
> Project: Thrift
> Issue Type: Bug
> Components: C# - Library
> Affects Versions: 0.9, 1.0
> Environment: Windows
> Reporter: Eric Ding
> Assignee: Henrique Mendonça
> Labels: PatchAvailable
> Fix For: 1.0
>
> Attachments: 1973-test-suite.patch, 1973-test-suite-v2.patch,
> thrift-1973-TCompactProtocol-Fix.patch
>
>
> longToZigzag and ZigzagToLong in TCompactProtocol does not perform
> corresponding operations to serialize and deserialize negative int32 and
> int64 number correctly. Purpose to change longToZigzag from
> (ulong)(((ulong)n << 1) ^ ((ulong)n >> 63)) to (ulong)(n << 1) ^ (ulong)(n >>
> 63).
> Will need to do same for intToZigZag. The reason is that we want arithmetic
> shift not logic shift.
> The test case in the project shows this, the output on server and client are
> different even though client received the same number back.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
