[
https://issues.apache.org/jira/browse/THRIFT-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13675913#comment-13675913
]
Konrad Grochowski commented on THRIFT-1986:
-------------------------------------------
I was checking exactly that (I've just used static_cast for code purity reasons
;) ), but it took me a while to get to old gcc :)
yeah it works, I just gonna check if it removes warning on visual also
> TCompactProtocol constants truncated on Windows (C4309)
> -------------------------------------------------------
>
> Key: THRIFT-1986
> URL: https://issues.apache.org/jira/browse/THRIFT-1986
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9
> Reporter: Konrad Grochowski
> Assignee: Roger Meier
> Priority: Critical
> Attachments: C4309_warning_removed.patch
>
>
> visual generates warnings about constant value truncation for lines like
> these:
> static const int8_t PROTOCOL_ID = (int8_t)0x82;
> To be honest - I'm not sure if that truncation really occurs, but there's an
> easy way to get rid of this warning (and probably portability problem)
> static const int8_t PROTOCOL_ID = 0x82u;
> Both lines generating warning in TCompactProtocol.h fixed in patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
