[ https://issues.apache.org/jira/browse/THRIFT-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13675927#comment-13675927 ]
Konrad Grochowski commented on THRIFT-1986: ------------------------------------------- ok, warning on visual did not appear, so both 'u' and cast is needed to fully satisfy both compilers ;) sorry for breaking the build still - I do not understand why gcc 4.6 fails (why it tries to generate address for that static variables) > TCompactProtocol constants truncated on Windows (C4309) > ------------------------------------------------------- > > Key: THRIFT-1986 > URL: https://issues.apache.org/jira/browse/THRIFT-1986 > Project: Thrift > Issue Type: Bug > Components: C++ - Library > Affects Versions: 0.9 > Reporter: Konrad Grochowski > Assignee: Roger Meier > Priority: Critical > Attachments: C4309_warning_removed.patch > > > visual generates warnings about constant value truncation for lines like > these: > static const int8_t PROTOCOL_ID = (int8_t)0x82; > To be honest - I'm not sure if that truncation really occurs, but there's an > easy way to get rid of this warning (and probably portability problem) > static const int8_t PROTOCOL_ID = 0x82u; > Both lines generating warning in TCompactProtocol.h fixed in patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira