yes, you are right.
git commit --signoff --author="Cross Everything <wo...@example.com>"
-a -m "THRIFT-XXXX lang: description"
does the trick!
I've just tested it here including also signoff:
https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=commit;h=cc25c52de4fc1d9d856a759b283ff96a6c251c29
https://issues.apache.org/jira/browse/THRIFT-2024
update here: http://thrift.apache.org/docs/HowToContribute ?
-roger
Quoting Carl Yeksigian <c...@yeksigian.com>:
I think it might be better attribution to use --author="(author)", if this
is for attribution.
That way the authorship can go to the person who authored the patch;
committer will remain the committer's name. Just for a preview, I just made
a test commit to a review branch on my github, so if interested in what
that might look like:
https://github.com/carlyeks/thrift/commit/2f96496856710c4bbff1890241b064561e0da2c6
On Jun 20, 2013, at 12:44 AM, Roger Meier <ro...@bufferoverflow.ch> wrote:
what about using the signoff feature for contributions?
git commit --signoff -a -m "THRIFT-XXXX lang: description"
roger
;-r
