[ 
https://issues.apache.org/jira/browse/THRIFT-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779990#comment-13779990
 ] 

Hudson commented on THRIFT-2210:
--------------------------------

FAILURE: Integrated in Thrift #918 (See 
[https://builds.apache.org/job/Thrift/918/])
THRIFT-2210: lib/java TSimpleJSONProtocol can emit invalid JSON (jfarrell: rev 
38b453be5a015b7aaefcd91b4e261e53e0e211c2)
* lib/java/src/org/apache/thrift/protocol/TSimpleJSONProtocol.java
* lib/java/test/org/apache/thrift/protocol/TestTSimpleJSONProtocol.java

                
> lib/java TSimpleJSONProtocol can emit invalid JSON
> --------------------------------------------------
>
>                 Key: THRIFT-2210
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2210
>             Project: Thrift
>          Issue Type: Bug
>            Reporter: Alex Levenson
>            Assignee: Alex Levenson
>             Fix For: 0.9.2
>
>         Attachments: THRIFT-2210-v1.patch
>
>
> TSimpleJSONProtocol can emit JSON with maps whose keys are not string (which 
> is not allowed is the JSON spec).
> This happens if the key in a map is anything other than a String (int, enum, 
> etc)
> For example, it can emit JSON like this: 
> {noformat}
> {"myMap":{5:"myValue"}}
> {noformat}
> which should be:
> {noformat}
> {"myMap":{"5":"myValue"}}
> {noformat}
> I have a path that fixes this, I'll upload it shortly (still trying to get my 
> dev environment to run the tests).
> Also AFAICT there is no unit test for TSimpleJSONProtocol -- I'll try and add 
> one to the patch.
> Thanks!
> Alex

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to