[
https://issues.apache.org/jira/browse/THRIFT-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13780002#comment-13780002
]
Jake Farrell commented on THRIFT-2210:
--------------------------------------
Passed all tests for me on java 1.7.0_25 on os x. looking into why jenkins did
not like this
junit-test:
[junit] Running org.apache.thrift.TestOptionals
[junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 0.042 sec
[junit] Running org.apache.thrift.TestShortStack
[junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 0.006 sec
[junit] Running org.apache.thrift.TestStruct
[junit] Tests run: 9, Failures: 0, Errors: 0, Time elapsed: 0.168 sec
[junit] Running org.apache.thrift.TestTBaseHelper
[junit] Tests run: 14, Failures: 0, Errors: 0, Time elapsed: 0.013 sec
[junit] Running org.apache.thrift.TestTDeserializer
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.134 sec
[junit] Running org.apache.thrift.TestTEnumHelper
[junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 0.022 sec
[junit] Running org.apache.thrift.TestTUnion
[junit] Tests run: 9, Failures: 0, Errors: 0, Time elapsed: 0.119 sec
[junit] Running org.apache.thrift.async.TestTAsyncClient
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.083 sec
[junit] Running org.apache.thrift.async.TestTAsyncClientManager
[junit] Tests run: 6, Failures: 0, Errors: 0, Time elapsed: 4.847 sec
[junit] Running org.apache.thrift.protocol.TestTCompactProtocol
[junit] Tests run: 12, Failures: 0, Errors: 0, Time elapsed: 0.141 sec
[junit] Running org.apache.thrift.protocol.TestTJSONProtocol
[junit] Tests run: 11, Failures: 0, Errors: 0, Time elapsed: 0.177 sec
[junit] Running org.apache.thrift.protocol.TestTProtocolUtil
[junit] Tests run: 4, Failures: 0, Errors: 0, Time elapsed: 0.081 sec
[junit] Running org.apache.thrift.protocol.TestTSimpleJSONProtocol
[junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 0.068 sec
[junit] Running org.apache.thrift.protocol.TestTTupleProtocol
[junit] Tests run: 12, Failures: 0, Errors: 0, Time elapsed: 0.146 sec
[junit] Running org.apache.thrift.scheme.TestStandardScheme
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.045 sec
[junit] Running org.apache.thrift.server.TestAsyncServer
[junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 7.012 sec
[junit] Running org.apache.thrift.server.TestHsHaServer
[junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 9.995 sec
[junit] Running org.apache.thrift.server.TestThreadedSelectorServer
[junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 10.03 sec
[junit] Running org.apache.thrift.transport.TestAutoExpandingBuffer
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.01 sec
[junit] Running
org.apache.thrift.transport.TestAutoExpandingBufferReadTransport
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.009 sec
[junit] Running
org.apache.thrift.transport.TestAutoExpandingBufferWriteTransport
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.008 sec
[junit] Running org.apache.thrift.transport.TestTFastFramedTransport
[junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 0.063 sec
[junit] Running org.apache.thrift.transport.TestTFramedTransport
[junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 0.068 sec
[junit] Running org.apache.thrift.transport.TestTMemoryInputTransport
[junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed: 0.008 sec
[junit] Running org.apache.thrift.transport.TestTSSLTransportFactory
[junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 4.267 sec
[junit] Running org.apache.thrift.transport.TestTSaslTransports
[junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 12.459 sec
[junit] Running org.apache.thrift.transport.TestTSimpleFileTransport
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.036 sec
deprecated-test:
test:
BUILD SUCCESSFUL
> lib/java TSimpleJSONProtocol can emit invalid JSON
> --------------------------------------------------
>
> Key: THRIFT-2210
> URL: https://issues.apache.org/jira/browse/THRIFT-2210
> Project: Thrift
> Issue Type: Bug
> Reporter: Alex Levenson
> Assignee: Alex Levenson
> Fix For: 0.9.2
>
> Attachments: THRIFT-2210-v1.patch
>
>
> TSimpleJSONProtocol can emit JSON with maps whose keys are not string (which
> is not allowed is the JSON spec).
> This happens if the key in a map is anything other than a String (int, enum,
> etc)
> For example, it can emit JSON like this:
> {noformat}
> {"myMap":{5:"myValue"}}
> {noformat}
> which should be:
> {noformat}
> {"myMap":{"5":"myValue"}}
> {noformat}
> I have a path that fixes this, I'll upload it shortly (still trying to get my
> dev environment to run the tests).
> Also AFAICT there is no unit test for TSimpleJSONProtocol -- I'll try and add
> one to the patch.
> Thanks!
> Alex
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
