[ https://issues.apache.org/jira/browse/THRIFT-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13848345#comment-13848345 ]
Jens Geyer commented on THRIFT-2232: ------------------------------------ +1 many thanks for the great work, Ben. [~traviscline], would you mind to have a look at it too? > IsSet* broken in Go > ------------------- > > Key: THRIFT-2232 > URL: https://issues.apache.org/jira/browse/THRIFT-2232 > Project: Thrift > Issue Type: Bug > Components: Go - Compiler > Reporter: Ben Sigelman > Labels: isset > Fix For: 0.9.2 > > Attachments: thrift-2232-golang-optional-fields-fix.patch > > > The various generated IsSetXYZ() methods just check for magic values of their > respective fields. This is obviously broken, and also diverges from the > implementation in other languages. > I am willing and able to fix this myself, but I don't want to start on any > impl until we can decide on an approach. > At this point, though, optional fields in Go are basically useless if one's > application makes use of the magic "absence" value. -- This message was sent by Atlassian JIRA (v6.1.4#6159)