[ https://issues.apache.org/jira/browse/THRIFT-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13915486#comment-13915486 ]
Aleksey Pesternikov commented on THRIFT-2232: --------------------------------------------- this fix broke binary keys (THRIFT-2247) again > IsSet* broken in Go > ------------------- > > Key: THRIFT-2232 > URL: https://issues.apache.org/jira/browse/THRIFT-2232 > Project: Thrift > Issue Type: Bug > Components: Go - Compiler > Reporter: Ben Sigelman > Assignee: Jens Geyer > Labels: isset > Fix For: 0.9.2 > > Attachments: THRIFT-2322_optional_set_assignment_issue.patch, > THRIFT-2322_regenerated_serializer_testfile.patch, > thrift-2232-golang-optional-fields-fix.patch > > > The various generated IsSetXYZ() methods just check for magic values of their > respective fields. This is obviously broken, and also diverges from the > implementation in other languages. > I am willing and able to fix this myself, but I don't want to start on any > impl until we can decide on an approach. > At this point, though, optional fields in Go are basically useless if one's > application makes use of the magic "absence" value. -- This message was sent by Atlassian JIRA (v6.1.5#6160)