[ 
https://issues.apache.org/jira/browse/THRIFT-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13870783#comment-13870783
 ] 

Henrique Mendonça commented on THRIFT-2205:
-------------------------------------------

+1 for that Pierre, we really need to improve the makefiles, autoconf and 
nodeunit integration...
the "node" command is called "nodejs" in some distributions and this should be 
caught in the autoconf

what about the standard "server.js -t buffered -p json" ? or --protocol=json
there are really nice libraries in npm for that, like 
https://github.com/visionmedia/commander.js

I'll be moving the tests to the lib folders when I get some more time, unless 
someone else wants to do that already... We should get this done before the 
next release so npm users can also see the tests.

- Henrique




> Node.js Test Server to support test.js JavaScript Browser test and sundry 
> fixes
> -------------------------------------------------------------------------------
>
>                 Key: THRIFT-2205
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2205
>             Project: Thrift
>          Issue Type: Improvement
>          Components: JavaScript - Library, Node.js - Library
>    Affects Versions: 1.0
>         Environment: All
>            Reporter: Randy Abernethy
>            Assignee: Randy Abernethy
>            Priority: Minor
>              Labels: node, nodejs
>             Fix For: 0.9.2
>
>         Attachments: 0001-node-test-update-with-JSON-Buf-fixes.patch, 
> 0002-node-Bin-Frame-client-server-test-update.patch, 
> 0003-node-throwed-error-should-be-instanciated.patch, 
> 0004-node-fix-TJSONProtocol-parser.patch, 
> 0005-node-tests-for-json-frame-and-bin-buf.patch, 
> 0006-node-fix-multiplexed-processor-for-buffered-transpor.patch
>
>
> Adds lib/nodejs/test/testsvr.js 
> This server depends on ThriftTest[.js] and runs clean with test.js in the 
> browser.
> Also in this patch:
> Repairs some shortfall in the Node JSON Protocol and transport. Fixes 
> overflow on Javascript I64 tests. Improves static_server header output.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to