[ https://issues.apache.org/jira/browse/THRIFT-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13868295#comment-13868295 ]
Randy Abernethy commented on THRIFT-2205: ----------------------------------------- [~jensg] Related patch notes: 2308 – Pierre reported this one and I think his patch here resolves 2308 but Pierre should confirm 2181 – I think this can be closed, multiple oneway calls are testing clean now 2171 – Resolved, though Henrique suggests moving thrift/test/nodejs to thrift/lib/nodejs/test 2068 – Resolved 1754 – Might be worth checking with Vesa the reporter, there is no code to repo this issue but from reading it I think that it is likely we have fixed the root cause since TBufferedTransport was involved in the report 1647 – Pierre supplied a patch for this Jira but I think his patches here supersede and resolve 1647, again I defer to Pierre. -Randy > Node.js Test Server to support test.js JavaScript Browser test and sundry > fixes > ------------------------------------------------------------------------------- > > Key: THRIFT-2205 > URL: https://issues.apache.org/jira/browse/THRIFT-2205 > Project: Thrift > Issue Type: Improvement > Components: JavaScript - Library, Node.js - Library > Affects Versions: 1.0 > Environment: All > Reporter: Randy Abernethy > Assignee: Randy Abernethy > Priority: Minor > Labels: node, nodejs > Fix For: 0.9.2 > > Attachments: 0001-node-test-update-with-JSON-Buf-fixes.patch, > 0002-node-Bin-Frame-client-server-test-update.patch, > 0003-node-throwed-error-should-be-instanciated.patch, > 0004-node-fix-TJSONProtocol-parser.patch, > 0005-node-tests-for-json-frame-and-bin-buf.patch, > 0006-node-fix-multiplexed-processor-for-buffered-transpor.patch > > > Adds lib/nodejs/test/testsvr.js > This server depends on ThriftTest[.js] and runs clean with test.js in the > browser. > Also in this patch: > Repairs some shortfall in the Node JSON Protocol and transport. Fixes > overflow on Javascript I64 tests. Improves static_server header output. -- This message was sent by Atlassian JIRA (v6.1.5#6160)