[
https://issues.apache.org/jira/browse/THRIFT-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13896069#comment-13896069
]
Roger Meier commented on THRIFT-2355:
-------------------------------------
cool stuff, Randy!
there's a little issue on my side:
{noformat}
$ git apply 0001-add-ssl-and-websocket-support-to-node-and-js.patch
0001-add-ssl-and-websocket-support-to-node-and-js.patch:133: trailing
whitespace.
grunt.registerTask('test', ['jshint', 'shell:InstallThriftJS',
0001-add-ssl-and-websocket-support-to-node-and-js.patch:134: trailing
whitespace.
'external_daemon:ThriftTestServer',
'external_daemon:ThriftTestServer_TLS',
0001-add-ssl-and-websocket-support-to-node-and-js.patch:135: trailing
whitespace.
'shell:ThriftGen', 'qunit:ThriftJS',
'qunit:ThriftJS_TLS',
0001-add-ssl-and-websocket-support-to-node-and-js.patch:138: trailing
whitespace.
grunt.registerTask('default', ['jshint', 'shell:InstallThriftJS',
0001-add-ssl-and-websocket-support-to-node-and-js.patch:139: trailing
whitespace.
'external_daemon:ThriftTestServer',
'external_daemon:ThriftTestServer_TLS',
error: patch failed: lib/js/test/server_http.js:39
error: lib/js/test/server_http.js: patch does not apply
error: patch failed: lib/js/test/test-jq.js:29
error: lib/js/test/test-jq.js: patch does not apply
error: patch failed: lib/js/test/test.html:34
error: lib/js/test/test.html: patch does not apply
{noformat}
what do you think about a common test key and certifiactes for testing
purposes, introduced via THRIFT-2325
could you use these instead of those lib/js/test/sec/cert.pem and
lib/js/test/sec/key.pem?
> Add SSL and Web Socket Support to Node and JavaScript
> -----------------------------------------------------
>
> Key: THRIFT-2355
> URL: https://issues.apache.org/jira/browse/THRIFT-2355
> Project: Thrift
> Issue Type: Improvement
> Components: JavaScript - Compiler, JavaScript - Library, Node.js -
> Library
> Affects Versions: 0.9.2
> Environment: all
> Reporter: Randy Abernethy
> Assignee: Randy Abernethy
> Priority: Minor
> Fix For: 0.9.2
>
> Attachments: 0001-add-ssl-and-websocket-support-to-node-and-js.patch
>
>
> This patch adds support for SSL between Node.js and Browser JavaScript as
> well as initial WebSocket transport support.
> The createStaticHTTPThriftServer() method has been renamed
> createThriftWebServer(). The resulting server supports XHR based HTTP:// and
> HTTPS:// clients as well as upgrades to WS:// and WSS:// for websocket
> clients.
> The JavaScript thrift.js library now includes websocket support through
> TWebSocketTransport. The old XHR transport still goes by the alias Transport
> but can now also be accessed through the name TXHRTransport. Browser clients
> can use XHR over HTTP and HTTPS (as always) and also WebSocket (WS://) and
> secure WebSocket (WSS://).
> The JavaScript grunt build runs jQuery and Normal JavaScript synchronous and
> asynchronous tests over HTTP and HTTPS. There are now three test drivers in
> the thrift/lib/js/test directory:
> - test.html the jQuery build test (thrift -gen js:jquery)
> - test-nojq.html the normal JavaScript build test (thrift -gen js)
> - testws.html the (in progress) web socket test.
> The thrift/lib/js/test/sec directory is new with a key.pem and cert.pem for
> the HTTPS test server.
> The root js README was updated and contains a complete client/server example.
> A new README was added to the test directory providing an orientation there.
> The web socket transport works but is experimental and incomplete. Hope to
> get it wrapped up over the next week. With Web Socket in place it makes sense
> to consider adding a binary protocol on the browser side.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
