[
https://issues.apache.org/jira/browse/THRIFT-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13922337#comment-13922337
]
Henrique Mendonça commented on THRIFT-2355:
-------------------------------------------
Hi Randy,
Thanks for clarifying.
That's totally fine, we are anyway free to implement any extension to the
library but it should be clear to the community why certain decisions were
made. I like your implementation (apart perhaps for using decimals to index
bits, Lol) and it seams to be neat and clear enough for further reuse, and we
still stay open for other implementations if it makes sense. As you has
probably seen on the other thread, my dream was to get socket.io to run with
thrift, as it also supports many target languages, but I never got time to
really test it. Perhaps one day after they release 1.0 :)
Generally, I totally with you about [ not ] adding new dependencies to Thrift.
However, I see it differently in the case of Node and NPM, and autoconf can be
used to handle optional dependencies for other languages.
Cheers,
Henrique
> Add SSL and Web Socket Support to Node and JavaScript
> -----------------------------------------------------
>
> Key: THRIFT-2355
> URL: https://issues.apache.org/jira/browse/THRIFT-2355
> Project: Thrift
> Issue Type: Improvement
> Components: JavaScript - Compiler, JavaScript - Library, Node.js -
> Library
> Affects Versions: 0.9.2
> Environment: all
> Reporter: Randy Abernethy
> Assignee: Randy Abernethy
> Priority: Minor
> Fix For: 0.9.2
>
> Attachments: 0001-Add-WebSocket-support-to-JS-and-Node.JS.patch
>
>
> This patch adds support for SSL between Node.js and Browser JavaScript as
> well as initial WebSocket transport support.
> The createStaticHTTPThriftServer() method has been renamed createWebServer().
> The resulting server supports XHR based HTTP:// and HTTPS:// clients as well
> as upgrades to WS:// and WSS:// for websocket clients.
> The JavaScript thrift.js library now includes websocket support through
> TWebSocketTransport. The old XHR transport still goes by the alias Transport
> but can now also be accessed through the name TXHRTransport. Browser clients
> can use XHR over HTTP and HTTPS (as always) and also WebSocket (WS://) and
> secure WebSocket (WSS://).
> The JavaScript grunt build runs jQuery and Normal JavaScript synchronous and
> asynchronous tests over HTTP and HTTPS. There are now three test drivers in
> the thrift/lib/js/test directory:
> - test.html the jQuery build test (thrift -gen js:jquery)
> - test-nojq.html the normal JavaScript build test (thrift -gen js)
> - testws.html the web socket test.
> The thrift/test/keys directory supplies the key and cert for the HTTPS test
> server.
> The root js README was updated and contains a complete client/server example.
> A new README was added to the test directory providing an orientation there.
> With WebSocket in place it makes sense to consider adding a binary protocol
> on the browser side.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
