[ 
https://issues.apache.org/jira/browse/THRIFT-2268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13910007#comment-13910007
 ] 

Jake Farrell commented on THRIFT-2268:
--------------------------------------

Hi [~thiruvel], thanks for the patch. Looking at this I do not see the need for 
a new exception type that is just caught and nothing occurs with it as 
TTransportException is already doing this. I see the value in the Sasl class 
adding the message as you are but would rather just throw a TTransportException 
with that same message instead of a new exception type. objections to removing 
the NotSaslException and changing to TTransportException?

> Modify TSaslTransport to ignore TCP health checks from loadbalancers
> --------------------------------------------------------------------
>
>                 Key: THRIFT-2268
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2268
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Java - Compiler
>    Affects Versions: 0.9
>            Reporter: Thiruvel Thirumoolan
>            Priority: Minor
>             Fix For: 0.9.2
>
>         Attachments: THRIFT-2268.patch
>
>
> Thrift Server with TSaslTransport throws TTransportExceptions when deployed 
> behind a hardware load balancer.
> We have deployed thrift servers HiveServer2 and HCatalog (both Apache Hive 
> components) behind hardware load balancers. The load balancer does a TCP 
> health check on the port where the thrift server (HiveServer2/HCatalog) is 
> running. Some of the load balancers complete the TCP handshake and then close 
> the connection without any data and therefore thrift has to handle it this 
> connection. Because the TCP health check happens very frequently - about 
> 10-20 times a minute, the logs are filled with TTransportExceptions. The 
> current logic assumes a valid header and if its not present (TCP health 
> check), then it keeps throwing exceptions.
> This JIRA attempts to ignore these which does not have a valid header.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to