[
https://issues.apache.org/jira/browse/THRIFT-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13954546#comment-13954546
]
Vanja Bucic commented on THRIFT-1766:
-------------------------------------
[^thrift-1.0.0-dev-rb-binary.patch]
adds 'binary' string attribute checking and appropriate method dispatch to
struct.c
I am wondering how did the original patch work without thrift_native.c,
constants.h, and struct.c having any reference to binary string type and
associated methods?
> [Ruby] Provide support for binary types
> ---------------------------------------
>
> Key: THRIFT-1766
> URL: https://issues.apache.org/jira/browse/THRIFT-1766
> Project: Thrift
> Issue Type: Sub-task
> Components: Ruby - Library
> Affects Versions: 0.9
> Reporter: Nathan Beyer
> Assignee: Nathan Beyer
> Attachments: THRIFT-1766-provide-support-for-binary-types.patch,
> thrift-1.0.0-dev-rb-binary.patch
>
>
> The Ruby library didn't provide explicit support for 'binary' types, which
> sort of worked on Ruby 1.8.7 and with Thrift 0.8, but it doesn't work with
> Ruby 1.9.3 and the encoding changes that were included with Thrift 0.9.
> This issue is intended to provide first class support for the 'binary' type.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
