[
https://issues.apache.org/jira/browse/THRIFT-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13954702#comment-13954702
]
Nathan Beyer commented on THRIFT-1766:
--------------------------------------
bq. I am wondering how did the original patch work without thrift_native.c,
constants.h, and struct.c having any reference to binary string type and
associated methods?
It probably worked because not all transport/protocol combinations use the
native extension code paths and not all consumers use the native extension
(it's optional).
Personally speaking, I'd prefer to eliminate all of the native code as it's
value is minor, especially with newer versions of Ruby, and it just makes the
code base very confusing and difficult to maintain.
> [Ruby] Provide support for binary types
> ---------------------------------------
>
> Key: THRIFT-1766
> URL: https://issues.apache.org/jira/browse/THRIFT-1766
> Project: Thrift
> Issue Type: Sub-task
> Components: Ruby - Library
> Affects Versions: 0.9
> Reporter: Nathan Beyer
> Assignee: Nathan Beyer
> Attachments: THRIFT-1766-provide-support-for-binary-types.patch,
> thrift-1.0.0-dev-rb-binary.patch
>
>
> The Ruby library didn't provide explicit support for 'binary' types, which
> sort of worked on Ruby 1.8.7 and with Thrift 0.8, but it doesn't work with
> Ruby 1.9.3 and the encoding changes that were included with Thrift 0.9.
> This issue is intended to provide first class support for the 'binary' type.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
