[ 
https://issues.apache.org/jira/browse/THRIFT-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958357#comment-13958357
 ] 

Randy Abernethy commented on THRIFT-2429:
-----------------------------------------

Hey Dave,

Thanks for posting the patch. Looks like you guys have already done all of the 
work. Should be easy to integrate when we have consensus.

I understand the PHP and Python issues. The inconsistent interface across 
languages for requiredness and (less so) for defaults has always troubled me. 
I'd like to see this initiative move us toward unifying things. Roger's cross 
language tests are exposing lots of corner case issues. It would be great if we 
could achieve a fully meshed and clean cross test by 1.0.

-Randy


> Provide option to not write default values, rely on receiver default 
> construction instead
> -----------------------------------------------------------------------------------------
>
>                 Key: THRIFT-2429
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2429
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Compiler
>    Affects Versions: 0.9.1
>            Reporter: Chris Stylianou
>            Assignee: Randy Abernethy
>              Labels: default, optional, required
>
> Would there be any objections to a patch that does not write default values 
> (essentially the same logic as the optional attributes). This obviously 
> relies on the receiving application using the same IDL version to ensure the 
> defaults used on object construction match the senders.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to