[ 
https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976951#comment-13976951
 ] 

Dave Watson commented on THRIFT-2471:
-------------------------------------

& vs. cpp.ref is a purely mechanical fix, changing it is no problem.  Checking 
recursion depth also seems reasonable, this is what protobufs does, and would 
still allow some graph API to be built on top.

I'm more interested in opinions on the type of pointer - shared vs. unique vs. 
raw with or without deletes.  

> Make cpp.ref annotation language agnostic
> -----------------------------------------
>
>                 Key: THRIFT-2471
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2471
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (General)
>            Reporter: Jens Geyer
>             Fix For: 0.9.2
>
>
> The proposal is to make the new {{cpp.ref}} annotation introduced with 
> THRIFT-2421 language agnostic instead of a C++ specialty only. 
> The annotation changes inlined nested structs into pointers to structs. This 
> behaviour is potentially relevant with all languages using value semantics 
> for nested structs etc.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to