[
https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13986115#comment-13986115
]
ASF GitHub Bot commented on THRIFT-2471:
----------------------------------------
GitHub user djwatson opened a pull request:
https://github.com/apache/thrift/pull/113
THRIFT-2471
three changes as discussed in THRIFT-2471:
* Update parser to use & instead of cpp.ref
* Recursion depth limit, a la protobufs
* shared_ptr instead of raw pointer w/deletes in the destructor.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/djwatson/thrift cpp.ref
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/113.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #113
----
commit 52b99af4ee1574253dcb77933d76a7ebb2d830df
Author: Dave Watson <davejwat...@fb.com>
Date: 2014-04-23T20:05:56Z
change cpp.ref to &
commit 3f9d31cc6140367529fd8f7b1b67056ec321786f
Author: Dave Watson <davejwat...@fb.com>
Date: 2014-04-23T21:50:29Z
Recursion depth limit
commit 61468e4534ce9e6a4f4f643bfd00542d13600d83
Author: Dave Watson <davejwat...@fb.com>
Date: 2014-04-25T19:59:18Z
shared_ptr for reference type
----
> Make cpp.ref annotation language agnostic
> -----------------------------------------
>
> Key: THRIFT-2471
> URL: https://issues.apache.org/jira/browse/THRIFT-2471
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (General)
> Reporter: Jens Geyer
> Fix For: 0.9.2
>
>
> The proposal is to make the new {{cpp.ref}} annotation introduced with
> THRIFT-2421 language agnostic instead of a C++ specialty only.
> The annotation changes inlined nested structs into pointers to structs. This
> behaviour is potentially relevant with all languages using value semantics
> for nested structs etc.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
