[
https://issues.apache.org/jira/browse/THRIFT-2560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014585#comment-14014585
]
Jens Geyer commented on THRIFT-2560:
------------------------------------
{quote}Clang says line 743 in t_d_generator.cc.{quote}
Indeed. Going to include that in my patch.
What bothers me a litte: Why do neither the other compilers we use nor tools
like coverity detect such comparingly simple bugs? Is there any reasonable
explanation? Any C++ gurus around who can explain this?
> Thrift compiler generator tries to concat ints with strings using +
> -------------------------------------------------------------------
>
> Key: THRIFT-2560
> URL: https://issues.apache.org/jira/browse/THRIFT-2560
> Project: Thrift
> Issue Type: Bug
> Components: C# - Compiler, Compiler (General), Delphi - Compiler
> Affects Versions: 0.9.1
> Environment: all
> Reporter: Jens Geyer
> Assignee: Jens Geyer
> Priority: Minor
> Fix For: 0.9.2
>
> Attachments:
> THRIFT-2560-Thrift-compiler-generator-tries-to-conca.patch
>
>
> As reported in THRIFT-2558, at several places in the Thrift language code
> generators an attenpt is made to throw a string by adding a string literal
> ("") and an int (t_base_type::t_base) in several places:
> {code}
> throw "compiler error: no C# name for base type " + tbase->get_base();
> {code}
> Additionally, at several places a wrong language name in these eror messages
> is used, probably due to the fact that most code generators are implemented
> re-using another, similar language's code generator.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
