[ 
https://issues.apache.org/jira/browse/THRIFT-2560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014606#comment-14014606
 ] 

Jens Geyer commented on THRIFT-2560:
------------------------------------

{quote}
The string literal is squirreled away in a data segment by the compiler and the 
address goes in its place. C++ allows you to do address arithmetic 
{quote}

Mmmh. In Pascal I can do address arithmetic as well, but even then I would need 
at least an explicitly written cast. Maybe that's why Real Programmers™ don't 
use Pascal ;-). Anyway, thanks for the explanation. BTW, updated my patch. I 
took the liberty to align your C# changes with the rest of the world. Is that 
ok?



> Thrift compiler generator tries to concat ints with strings using +
> -------------------------------------------------------------------
>
>                 Key: THRIFT-2560
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2560
>             Project: Thrift
>          Issue Type: Bug
>          Components: C# - Compiler, Compiler (General), Delphi - Compiler
>    Affects Versions: 0.9.1
>         Environment: all
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>            Priority: Minor
>             Fix For: 0.9.2
>
>         Attachments: 
> THRIFT-2560-Thrift-compiler-generator-tries-to-conca-V2.patch
>
>
> As reported in THRIFT-2558, at several places in the Thrift language code 
> generators an attenpt is made to throw a string by adding a string literal 
> ("") and an int (t_base_type::t_base) in several places:
> {code}
> throw "compiler error: no C# name for base type " + tbase->get_base();
> {code}
> Additionally, at several places a wrong language name in these eror messages 
> is used, probably due to the fact that most code generators are implemented 
> re-using another, similar language's code generator.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to