[
https://issues.apache.org/jira/browse/THRIFT-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14072962#comment-14072962
]
ASF GitHub Bot commented on THRIFT-2628:
----------------------------------------
GitHub user talentdeficit opened a pull request:
https://github.com/apache/thrift/pull/164
THRIFT-2628 erlang: struct member name conflicts due to lowercased
names
client: erlang
patch: talentdeficit (alisdair sullivan)
preserve case in generated field names (via erlang 'atom' form)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/talentdeficit/thrift THRIFT-2628
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/164.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #164
----
commit a908ee80940e9f3cd7ab09999a17b658d5300efb
Author: alisdair sullivan <alisdairsulli...@yahoo.ca>
Date: 2014-07-23T06:40:44Z
THRIFT-2628 erlang: struct member name conflicts due to lowercased
names
client: erlang
patch: talentdeficit (alisdair sullivan)
preserve case in generated field names (via erlang 'atom' form)
----
> erlang: struct member name conflicts due to lowercased names
> ------------------------------------------------------------
>
> Key: THRIFT-2628
> URL: https://issues.apache.org/jira/browse/THRIFT-2628
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Compiler, Erlang - Library
> Reporter: alisdair sullivan
> Labels: erlang
>
> the erlang backend generates records to represent structs. instead of the
> unique sequential id they use the struct field name as the record keys.
> records in erlang do not support repeated keys so generated erlang modules do
> not compile
> the most obvious fix is to refuse to generate code from structs with repeated
> keys but this means the erlang backend is not capable of handling all valid
> structs
> the easiest fix is to switch structs to use the unique sequential ids as the
> keys of the record but this breaks backwards compatibility and probably
> necessitates generating helper functions to retrieve fields by name
> also possible is switching to an erlang data structure that supports repeated
> keys but this would also require breaking backwards compatibility
--
This message was sent by Atlassian JIRA
(v6.2#6252)
