[ 
https://issues.apache.org/jira/browse/THRIFT-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14073772#comment-14073772
 ] 

Hudson commented on THRIFT-2628:
--------------------------------

FAILURE: Integrated in Thrift #1230 (See 
[https://builds.apache.org/job/Thrift/1230/])
THRIFT-2628 erlang: struct member name conflicts due to lowercased names 
(roger: rev fb6ed7ead165cc494bda7d59691a33809281ef3a)
* compiler/cpp/src/generate/t_erl_generator.cc
* lib/erl/test/nameConflictTest_test.erl


> erlang: struct member name conflicts due to lowercased names
> ------------------------------------------------------------
>
>                 Key: THRIFT-2628
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2628
>             Project: Thrift
>          Issue Type: Bug
>          Components: Erlang - Compiler, Erlang - Library
>            Reporter: alisdair sullivan
>            Assignee: Roger Meier
>              Labels: erlang
>
> the erlang backend generates records to represent structs. instead of the 
> unique sequential id they use the struct field name as the record keys. 
> records in erlang do not support repeated keys so generated erlang modules do 
> not compile
> the most obvious fix is to refuse to generate code from structs with repeated 
> keys but this means the erlang backend is not capable of handling all valid 
> structs
> the easiest fix is to switch structs to use the unique sequential ids as the 
> keys of the record but this breaks backwards compatibility and probably 
> necessitates generating helper functions to retrieve fields by name
> also possible is switching to an erlang data structure that supports repeated 
> keys but this would also require breaking backwards compatibility



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to