[ 
https://issues.apache.org/jira/browse/THRIFT-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14101090#comment-14101090
 ] 

ASF GitHub Bot commented on THRIFT-2668:
----------------------------------------

Github user bufferoverflow commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/194#discussion_r16374841
  
    --- Diff: test/py/TestClient.py ---
    @@ -94,29 +111,91 @@ def tearDown(self):
         # Close!
         self.transport.close()
     
    +  @classmethod
    +  def tearDownClass(cls):
    +    ret = 255 - TEST_NOTUSED
    +    if(not test_basetypes_fails):
    +      ret = ret - TEST_BASETYPES
    +    if(not test_structs_fails):
    +      ret = ret - TEST_STRUCTS
    +    if(not test_containers_fails):
    +      ret = ret - TEST_CONTAINERS
    +    if(not test_exceptions_fails):
    +      ret = ret - TEST_EXCEPTIONS
    +    if(not test_complex_fails):
    +      ret = ret - TEST_COMPLEX
    +    if(not test_enumtypedef_fails):
    +      ret = ret - TEST_ENUMTYPEDEF
    +    if(not test_oneway_fails):
    +      ret = ret - TEST_ONEWAY
    +
    --- End diff --
    
    return ret?


> TestSuite: detailed result on passed tests by feature
> -----------------------------------------------------
>
>                 Key: THRIFT-2668
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2668
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: Test Suite
>            Reporter: Roger Meier
>
> return code shall be 0 on success or an integer in the range 1 - 255 on error
> as mentioned http://thrift.apache.org/test
> We can define bit fields for the byte we pass as return code:
> {noformat}
> #define TEST_BASETYPES     1  // 0000 0001
> #define TEST_STRUCTS       2  // 0000 0010
> #define TEST_CONTAINERS    4  // 0000 0100
> #define TEST_EXCEPTIONS    8  // 0000 1000
> #define TEST_NOTUSED     240  // 1111 0000 
> {noformat}
> this will help us to see which tests passed 
> a TestClient will do this:
> {noformat}
> ret = 255 - TEST_NOTUSED
> if testBaseTypes == passed
>   ret = ret - TEST_BASETYPES
> if testStructs == passed
>   ret = ret - TEST_STRUCTS
> if testContainers == passed
>   ret = ret - TEST_CONTAINERS
> if testExceptions == passed
>   ret = ret - TEST_EXCEPTIONS
> return ret
> {noformat}
> test suite reporting can take care on the individual test status



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to