[
https://issues.apache.org/jira/browse/THRIFT-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14103749#comment-14103749
]
ASF GitHub Bot commented on THRIFT-2668:
----------------------------------------
Github user cdwijayarathna commented on the pull request:
https://github.com/apache/thrift/pull/194#issuecomment-52760264
@bufferoverflow committed suggested changes in java, cpp, py.
Since python uses unittest framework, using exit(ret), stopped printing
failure details of failed tests in command line.
eg:-
FAIL: testString (__main__.NormalBinaryTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "py/TestClient.py", line 125, in testString
raise AssertionError( e.args )
AssertionError:
("'PythonPythonPythonPythonPythonPythonPythonPythonPythonPythonPythonPythonPythonPythonPythonPythonPythonPythonPythonPython'
!=
'PythoPythoPythoPythoPythoPythoPythoPythoPythoPythoPythoPythoPythoPythoPythoPythoPythoPythoPythoPytho'",)
----------------------------------------------------------------------
Ran 18 tests in 1.256s
FAILED (failures=1)
I couldn't found any way to exit(ret) with keeping above, I'll check more
if any better solution.
Ruby is also 75% implemented, I'll finish it soon and commit.
> TestSuite: detailed result on passed tests by feature
> -----------------------------------------------------
>
> Key: THRIFT-2668
> URL: https://issues.apache.org/jira/browse/THRIFT-2668
> Project: Thrift
> Issue Type: Sub-task
> Components: Test Suite
> Reporter: Roger Meier
>
> return code shall be 0 on success or an integer in the range 1 - 255 on error
> as mentioned http://thrift.apache.org/test
> We can define bit fields for the byte we pass as return code:
> {noformat}
> #define TEST_BASETYPES 1 // 0000 0001
> #define TEST_STRUCTS 2 // 0000 0010
> #define TEST_CONTAINERS 4 // 0000 0100
> #define TEST_EXCEPTIONS 8 // 0000 1000
> #define TEST_NOTUSED 240 // 1111 0000
> {noformat}
> this will help us to see which tests passed
> a TestClient will do this:
> {noformat}
> ret = 255 - TEST_NOTUSED
> if testBaseTypes == passed
> ret = ret - TEST_BASETYPES
> if testStructs == passed
> ret = ret - TEST_STRUCTS
> if testContainers == passed
> ret = ret - TEST_CONTAINERS
> if testExceptions == passed
> ret = ret - TEST_EXCEPTIONS
> return ret
> {noformat}
> test suite reporting can take care on the individual test status
--
This message was sent by Atlassian JIRA
(v6.2#6252)
