[ 
https://issues.apache.org/jira/browse/THRIFT-2796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14220029#comment-14220029
 ] 

Frank Schroeder commented on THRIFT-2796:
-----------------------------------------

Added pull request https://github.com/apache/thrift/pull/278 for the test case 
but I'm having some difficulties compiling thrift tip on OSX Yosemite 
(10.10.1). The compiler stops with the following error:

{code}
/Applications/Xcode.app/Contents/Developer/usr/bin/make  all-recursive
Making all in compiler/cpp
\
         \
        /bin/sh ../../ylwrap `test -f 'src/thrifty.yy' || echo 
'./'`src/thrifty.yy y.tab.c thrifty.cc y.tab.h `echo thrifty.cc | sed -e 
s/cc$/hh/ -e s/cpp$/hpp/ -e s/cxx$/hxx/ -e s/c++$/h++/ -e s/c$/h/` y.output 
thrifty.output -- /opt/boxen/homebrew/Cellar/bison27/2.7.1/bin/bison -d
updating thriftthrifty.ccc
updating thriftthrifty.hhh
/Applications/Xcode.app/Contents/Developer/usr/bin/make  all-am
\
         \
        /bin/sh ../../ylwrap `test -f 'src/thrifty.yy' || echo 
'./'`src/thrifty.yy y.tab.c thrifty.cc y.tab.h `echo thrifty.cc | sed -e 
s/cc$/hh/ -e s/cpp$/hpp/ -e s/cxx$/hxx/ -e s/c++$/h++/ -e s/c$/h/` y.output 
thrifty.output -- /opt/boxen/homebrew/Cellar/bison27/2.7.1/bin/bison -d
thriftthrifty.ccc is unchanged
thriftthrifty.hhh is unchanged
g++ -DHAVE_CONFIG_H -I. -I../.. -I../../lib/cpp/src/thrift  -I./src  -Wall 
-Wno-sign-compare -Wno-unused -g -O2 -std=c++11 -MT libparse_a-thrifty.o -MD 
-MP -MF .deps/libparse_a-thrifty.Tpo -c -o libparse_a-thrifty.o `test -f 
'thrifty.cc' || echo './'`thrifty.cc
clang: error: no such file or directory: './thrifty.cc'
clang: error: no input files
make[3]: *** [libparse_a-thrifty.o] Error 1
make[2]: *** [all] Error 2
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2
{code}

Tried to compile tip then on Ubuntu 12.04 but didn't manage to install all 
build deps. Currently stuck at

{code}
vagrant@devbox:~/dev/thrift$ ./bootstrap.sh
configure.ac:103: warning: macro `AM_EXTRA_RECURSIVE_TARGETS' not found in 
library
configure.ac:103: error: possibly undefined macro: AM_EXTRA_RECURSIVE_TARGETS
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
vagrant@devbox:~/dev/thrift$ ../configure-thrift-go
configure: error: cannot find install-sh, install.sh, or shtool in . "."/.
vagrant@devbox:~/dev/thrift$ which shtool
/usr/bin/shtool
{code}

configure-thrift-go is a helper script 

{code}
#!/bin/bash

./configure \
        --without-cpp \
        --without-qt4 \
        --without-c_glib \
        --without-csharp \
        --with-java \
        --without-erlang \
        --without-nodejs \
        --without-lua \
        --without-python \
        --without-perl \
        --without-php \
        --without-php_extension \
        --without-ruby \
        --without-haskell \
        --with-go
{code}

Help or a code review of the test is appreciated.

Thx
Frank

> Testcase for THRIFT-2793
> ------------------------
>
>                 Key: THRIFT-2796
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2796
>             Project: Thrift
>          Issue Type: Test
>          Components: Go - Compiler
>            Reporter: Jens Geyer
>             Fix For: 1.0
>
>
> Add test for THRIFT-2793 Go compiler produces uncompilable code



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to